Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirements for Trust Policy management. #89

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add requirements for Trust Policy management. #89

wants to merge 1 commit into from

Conversation

gokarnm
Copy link
Contributor

@gokarnm gokarnm commented Jul 14, 2021

PR for #83 , Trust Policy management and Trust store updates, there are no comments on the corresponding hackdoc to track. Also created a new folder for requirements so that we don't crowd the top level dir.

Signed-off-by: Milind Gokarn milind81@gmail.com

Signed-off-by: Milind Gokarn <milind81@gmail.com>

Deployers who consume signed artifacts from a registry require that only artifacts from trusted parties are deployed and executed. The trusted parties are specified in some form of a trust policy against which the signed artifacts are validated. The trust policy can include a trust store with trusted root and leaf keys/certificates which represent the Publisher identities the Deployer trusts. This section covers where the trust policies should be stored, and how they are distributed/updated.

Root keys form the basis of hierarchical trust systems, where intermediate and leaf keys chain back to a root key, and leaf keys are used to generate signatures. Consumers of signed artifacts associate a baseline level of trust with signatures that chain to roots they trust. In the scenario that a root key is no longer trusted, all signed artifacts chaining back to the root are no longer trusted. The conditions which render the root keys to be no longer trusted, are disclosed to the customer through some other channel (CVE, internal security audit, etc.). Safe rotation of keys require a overlap period where both new and old root keys are trusted. This is always not possible, such as when a root key is compromised.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roots and intermediates should also be able to delegate a subset of control using namespacing so that the owner of a leaf key is only trusted to sign the artifacts that they are responsible for.

Copy link
Contributor

@mnm678 mnm678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. I left a few comments about limitations of trust/namespacing.

2. A Publisher’s repository may contain a mix of artifacts, published by different teams using different keys. The Deployer wants to trust only artifacts signed by specific keys.
- E.g. A group may include the MySQL image from docker hub, and the MySQL Helm chart from another group in the same registry/repo. These are signed by different entities, and valid to be placed in the same repository.

#### Scenarios for Trust Store Updates
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also add a scenario for a root/intermediary revoking/replacing a delegated key.

- Trust policies need not be stored in another location
- Allows in band/automated distribution and update of trust policies to consumers.

Cons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also a timeliness issue. If new policies are added, the registry would also need to provide a way to ensure you're getting the most recent policy.

- This model does not allow Deployers to independently define trust policies. Furthermore, it may be required that Deployer Admins define trusted publishers, and Deployer Operators only specify/configure which artifacts (from repositories) are deployed.

## Recommendation
- Trust policies SHOULD NOT be stored in the registry. Multiple Deployers can consume artifacts from the same repository, and may need to define trust policies independently.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A potential downside is that the user would need to access a third-party service, which was one of the complaints about notary v1.

@iamsamirzon iamsamirzon added this to the alpha-2 milestone Oct 12, 2021
@SteveLasker
Copy link
Contributor

@gokarnm, Has this been captured in the signature specs?

@dtzar dtzar modified the milestones: alpha-2, rc.1 Jun 8, 2022
@iamsamirzon iamsamirzon linked an issue Aug 10, 2022 that may be closed by this pull request
@iamsamirzon
Copy link

This PR will complete the last remaining issue around Trust Policy mgmt, and once merged we can close #83

@yizha1
Copy link
Contributor

yizha1 commented Mar 27, 2023

@iamsamirzon @gokarnm @priteshbandi Any suggestions on how to move this PR forward? It has been open for quite a long time. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Management - Trust Policy Management and Trust Store Updates
6 participants