Skip to content

Commit

Permalink
feat: remove npm birthday (#5455)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: this removes the `npm birthday` command
  • Loading branch information
wraithgar authored Sep 8, 2022
1 parent 285b39f commit 49bbb2f
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 45 deletions.
17 changes: 0 additions & 17 deletions lib/commands/birthday.js

This file was deleted.

2 changes: 1 addition & 1 deletion lib/utils/cmd-list.js
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const cmdList = [
'whoami',
]

const plumbing = ['birthday', 'help-search']
const plumbing = ['help-search']
const abbrevs = abbrev(cmdList.concat(Object.keys(aliases)))

module.exports = {
Expand Down
9 changes: 0 additions & 9 deletions tap-snapshots/test/lib/load-all-commands.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,6 @@ Options:
Run "npm help audit" for more info
`

exports[`test/lib/load-all-commands.js TAP load each command birthday > must match snapshot 1`] = `
Birthday, deprecated
Usage:
npm birthday
Run "npm help birthday" for more info
`

exports[`test/lib/load-all-commands.js TAP load each command bugs > must match snapshot 1`] = `
Report bugs for a package in a web browser
Expand Down
1 change: 0 additions & 1 deletion tap-snapshots/test/lib/utils/cmd-list.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,6 @@ Object {
"whoami",
],
"plumbing": Array [
"birthday",
"help-search",
],
}
Expand Down
15 changes: 0 additions & 15 deletions test/lib/commands/birthday.js

This file was deleted.

4 changes: 2 additions & 2 deletions test/lib/npm.js
Original file line number Diff line number Diff line change
Expand Up @@ -574,10 +574,10 @@ t.test('aliases and typos', async t => {
const { npm } = await loadMockNpm(t, { load: false })
await t.rejects(npm.cmd('thisisnotacommand'), { code: 'EUNKNOWNCOMMAND' })
await t.rejects(npm.cmd(''), { code: 'EUNKNOWNCOMMAND' })
await t.rejects(npm.cmd('birt'), { code: 'EUNKNOWNCOMMAND' })
await t.rejects(npm.cmd('birthday'), { code: 'EUNKNOWNCOMMAND' })
await t.resolves(npm.cmd('it'), { name: 'install-test' })
await t.resolves(npm.cmd('installTe'), { name: 'install-test' })
await t.resolves(npm.cmd('birthday'), { name: 'birthday' })
await t.resolves(npm.cmd('access'), { name: 'access' })
})

t.test('explicit workspace rejection', async t => {
Expand Down

0 comments on commit 49bbb2f

Please sign in to comment.