Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: for readability #130

Closed
wants to merge 1 commit into from
Closed

Conversation

jjangga0214
Copy link

@jjangga0214 jjangga0214 commented Dec 21, 2018

  • If there are many expression(e.g. ternary operator ) in template literal, it would be a bit hard to read. So making it concise helps us.
  • Also, if the template literal is to be printed on screen, it's good to be in similar form (location of line break \n or a special character like for example) from what users actually see.
  • What's more, by improving it in the manner, sometimes number of lines could be reduced, in a good way.

Therefore I refactored a little.

@jjangga0214 jjangga0214 requested a review from a team as a code owner December 21, 2018 15:17
Copy link
Contributor

@aeschright aeschright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're going to reject this because there's an open patch on the same part of the code and it will cause conflicts. I appreciate your interest in working on the readability of the code -- feel free to look for places that in-progress work can be improved!
Ref: #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants