Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace rimraf with fs.rm #5946

Merged
merged 1 commit into from
Dec 17, 2022
Merged

fix: replace rimraf with fs.rm #5946

merged 1 commit into from
Dec 17, 2022

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner December 10, 2022 00:27
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Dec 10, 2022 •
edited
Loading

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 52.286 ±5.38 27.006 ±0.09 36.526 ±16.41 28.676 ±1.63 4.248 ±0.15 4.657 ±0.24 3.458 ±0.05 17.567 ±0.13 3.540 ±0.05 5.187 ±0.21
#5946 52.074 ±4.85 25.863 ±0.22 36.200 ±14.25 28.006 ±1.24 4.138 ±0.09 4.316 ±0.14 3.398 ±0.06 17.027 ±0.20 3.244 ±0.01 4.901 ±0.04
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 35.139 ±2.31 20.317 ±0.05 18.592 ±0.19 20.054 ±0.89 3.914 ±0.17 3.986 ±0.07 3.398 ±0.02 12.937 ±0.16 3.305 ±0.07 4.671 ±0.29
#5946 33.634 ±1.67 19.727 ±0.05 17.988 ±0.05 19.474 ±1.19 4.022 ±0.24 3.957 ±0.19 3.325 ±0.13 12.867 ±0.28 3.222 ±0.06 4.457 ±0.04

wraithgar
wraithgar approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fs.rm was introduced in v14.14.0
npm.engines is set to ^14.17.0

@lukekarrys lukekarrys merged commit 28ec922 into latest Dec 17, 2022
@lukekarrys lukekarrys deleted the deps/rimraf branch December 17, 2022 03:33
@github-actions github-actions bot mentioned this pull request Dec 17, 2022
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Jan 12, 2023
Merged
luislobo
luislobo reviewed Jan 13, 2023
View reviewed changes
test/lib/utils/log-file.js
'fs/promises': {
rm: async (...args) => {
if (count >= 3) {
throw new Error('bad rimraf')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not say rimraf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luislobo luislobo luislobo left review comments

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukekarrys @npm-cli-bot @wraithgar @luislobo