Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove package-lock option for npm ci #6468

Merged
merged 4 commits into from
May 18, 2023
Merged

docs: remove package-lock option for npm ci #6468

merged 4 commits into from
May 18, 2023

Conversation

m4rch3n1ng
Copy link
Contributor

running npm help ci and npm ci --help suggests the option package-lock and --no-package-lock respectively, even though the npm help ci explicitly states that this has no effect on npm ci.
this also applies to npm help install-ci-test and npm install-ci-test --help.

this pr would remove that unnecessary option suggestion.

@m4rch3n1ng m4rch3n1ng requested a review from a team as a code owner May 18, 2023 17:42
@@ -1495,8 +1495,6 @@ define('package-lock', {
If set to false, then ignore \`package-lock.json\` files when installing.
This will also prevent _writing_ \`package-lock.json\` if \`save\` is
true.

This configuration does not affect \`npm ci\`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thinking here is that now that this isn't listed as a flag on npm ci the caveat isn't needed.

@wraithgar wraithgar merged commit c3638ce into npm:latest May 18, 2023
@github-actions github-actions bot mentioned this pull request May 18, 2023
@m4rch3n1ng m4rch3n1ng deleted the ci-no-package-lock branch May 19, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants