Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use @npmcli/redact for url cleaning #7363

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Apr 10, 2024

I missed these calls when first moving to @npmcli/redact. This isn't a performance specific PR but I assume it will help since there are now a few places where we no longer need to require npm-registry-fetch at all.

@lukekarrys lukekarrys requested a review from a team as a code owner April 10, 2024 18:22
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this once it goes green.

@wraithgar wraithgar merged commit ef381b1 into latest Apr 10, 2024
37 checks passed
@wraithgar wraithgar deleted the lk/use-redact-in-more-places branch April 10, 2024 18:52
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
@ibrahimkhled

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants