Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reify): cleanup of Symbols #7430

Merged
merged 1 commit into from
Apr 30, 2024
Merged

fix(reify): cleanup of Symbols #7430

merged 1 commit into from
Apr 30, 2024

Conversation

wraithgar
Copy link
Member

This starts the long process of cleaning reify.js up. All of the
remaining symbols are used either elsewhere in arborist, or in tests.

A single use function was inlined, and dedupe was moved to the main
arborist class.

This starts the long process of cleaning reify.js up.  All of the
remaining symbols are used either elsewhere in arborist, or in tests.

A single use function was inlined, and `dedupe` was moved to the main
arborist class.
@wraithgar wraithgar marked this pull request as ready for review April 26, 2024 16:47
@wraithgar wraithgar requested a review from a team as a code owner April 26, 2024 16:47
Copy link
Contributor

@lukekarrys lukekarrys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This represents a ton of work that will be very beneficial going forward! 👏🏼

@wraithgar wraithgar merged commit abcbc54 into latest Apr 30, 2024
20 checks passed
@wraithgar wraithgar deleted the gar/arborist-cleanup branch April 30, 2024 20:10
@github-actions github-actions bot mentioned this pull request Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants