Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): be more aggressive about hiding protected values #7504

Merged
merged 1 commit into from
May 10, 2024

Conversation

wraithgar
Copy link
Member

Err on the side of not displaying things even if they're not valid config

@wraithgar wraithgar requested a review from a team as a code owner May 10, 2024 14:37
Comment on lines +359 to +362
_auth = (protected)
//nerfdart:_auth = (protected)
//nerfdart:auth = (protected)
auth = (protected)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here is the actual new snapshot, whitespace fix notwithstanding.

Err on the side of not displaying things even if they're not valid config
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 10, 2024

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 32.508 ±1.31 10.487 ±0.01 11.635 ±0.10 1.556 ±0.04 1.592 ±0.00 1.301 ±0.00 8.210 ±0.04 1.298 ±0.00 0.139 ±0.00 0.168 ±0.00 13.930 ±0.10 3.672 ±2.25
#7504 33.603 ±2.26 10.511 ±0.07 11.604 ±0.08 1.549 ±0.02 1.558 ±0.03 1.268 ±0.01 8.445 ±0.10 1.327 ±0.02 0.142 ±0.00 0.171 ±0.00 14.803 ±0.20 2.120 ±0.02
app-medium clean lock-only cache-only modules-only no-lock no-cache no-modules no-clean show-version run-script cache-only
peer-deps
no-clean
audit
npm@latest 25.287 ±0.86 8.174 ±0.03 9.067 ±0.02 1.568 ±0.00 1.575 ±0.02 1.464 ±0.00 5.905 ±0.02 1.355 ±0.01 0.143 ±0.00 0.167 ±0.00 9.432 ±0.03 3.070 ±1.58
#7504 26.465 ±0.24 7.774 ±0.04 8.738 ±0.05 1.502 ±0.02 1.487 ±0.00 1.386 ±0.01 5.714 ±0.00 1.297 ±0.04 0.135 ±0.00 0.163 ±0.00 10.049 ±0.03 1.948 ±0.02

@wraithgar wraithgar merged commit db62910 into latest May 10, 2024
23 checks passed
@wraithgar wraithgar deleted the gar/config-protect-more branch May 10, 2024 15:43
@github-actions github-actions bot mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants