Skip to content
This repository has been archived by the owner on May 10, 2021. It is now read-only.

chore(dirPacker): add dirPacker to options #4

Closed
wants to merge 2 commits into from

Conversation

claudiahdz
Copy link
Contributor

@claudiahdz claudiahdz commented Sep 16, 2019

✏️ Changes

This PR adds a test to make sure dirPacker is correctly defined on extract and ensures no functions are passed to lifecycle options.

🔗 References

See: npm/cli#252
Fixes: https://npm.community/t/npm-6-11-2-npm-ci-not-copying-prepared-files/9718

🔍 Testing

Automated testing

  • Checks if extract.child() ensures dirPacker is defined

✅ This change has unit test coverage

@isaacs isaacs closed this in 576ab36 Sep 24, 2019
claudiahdz added a commit that referenced this pull request Oct 8, 2019
- add dirPacker to options
- set dirPacker to null on lifecycle options

PR-URL: #4
Credit: @claudiahdz
Close: #4
Reviewed-by: @isaacs
claudiahdz added a commit that referenced this pull request Oct 8, 2019
- add dirPacker to options
- set dirPacker to null on lifecycle options

PR-URL: #4
Credit: @claudiahdz
Close: #4
Reviewed-by: @isaacs
claudiahdz added a commit that referenced this pull request Oct 9, 2019
- add dirPacker to options
- set dirPacker to null on lifecycle options

PR-URL: #4
Credit: @claudiahdz
Close: #4
Reviewed-by: @isaacs
@claudiahdz claudiahdz deleted the claudiahdz/npmci-config branch October 9, 2019 12:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant