New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow overriding npm_ env vars via env #222

Open

legobeat wants to merge 2 commits into npm:main from legobeat:env-var-overrides

legobeat commented Sep 30, 2024 •

edited

Loading

Allow user to override the following env vars via env params:

npm_package_json
npm_lifecycle_event
npm_lifecycle_script

Package defaults still take precedence over process.env.

Precendence order before:

Package defaults
env param
process.env

Precendence order after:

env param
Package defaults
process.env

Related

Based on fix: autolocation of node-gyp in make-spawn-args #221
- This PR goes one step further compared to base 221.
[BUG] The npm_config_node_gyp environment variable and npm config set node-gyp config don't work with npm 7 #23
[BUG] config var "node-gyp" not respected in npm 7 cli#2839

legobeat changed the title ~~env var overrides~~ fix: allow overrideing npm_ env vars via env

legobeat force-pushed the env-var-overrides branch from c54cc18 to 8f5627d Compare

September 30, 2024 01:39

legobeat changed the title ~~fix: allow overrideing npm_ env vars via env~~ fix: allow overriding npm_ env vars via env

legobeat marked this pull request as ready for review

September 30, 2024 01:43

legobeat requested a review from a team as a code owner

September 30, 2024 01:43

This was referenced Sep 30, 2024

[BUG] config var "node-gyp" not respected in npm 7 npm/cli#2839

Open

[BUG] The npm_config_node_gyp environment variable and npm config set node-gyp config don't work with npm 7 #23

Open

legobeat added 2 commits

October 3, 2024 05:15


          fix: defensive autolocation of node-gyp in make-spawn-args

c936a18

prevents runtime error in environments where `require.resolve` is not
available

Fall back to any existing `npm_config_node_gyp` provided by environment


          fix(make-spawn-args): allow overriding npm_ env vars via env

3a4d7e4

legobeat force-pushed the env-var-overrides branch from 8f5627d to 3a4d7e4 Compare

October 3, 2024 05:15

legobeat mentioned this pull request

fix: autolocation of node-gyp in make-spawn-args #221

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet