fix: account for new npm-package-arg behavior

npm · Oct 18, 2022 · a722962 · a722962
1 parent 6fe7663
commit a722962
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 10 deletions.
diff --git a/lib/check/check-required.js b/lib/check/check-required.js
@@ -36,7 +36,7 @@ const run = ({ pkg, path, config: { requiredPackages = {} } }) => {
 
       return {
         title: `The following required ${location} were not found:`,
-        body: specs.map((s) => s.rawSpec ? `${s.name}@${s.rawSpec}` : s.name),
+        body: specs.map((s) => s.rawSpec === '*' ? s.name : `${s.name}@${s.rawSpec}`),
         // solution is to remove any existing all at once but add back in by --save-<location>
         solution: [
           rmCommand(specs),

diff --git a/lib/util/has-package.js b/lib/util/has-package.js
@@ -20,10 +20,6 @@ const getSpecVersion = (spec, where) => {
   switch (arg.type) {
     case 'range':
       return new semver.Range(arg.fetchSpec)
-    case 'tag': {
-      // special case an empty spec to mean any version
-      return arg.rawSpec === '' && new semver.Range('*')
-    }
     case 'version':
       return new semver.SemVer(arg.fetchSpec)
     case 'directory': {

diff --git a/tap-snapshots/test/check/snapshots.js.test.cjs b/tap-snapshots/test/check/snapshots.js.test.cjs
@@ -103,7 +103,7 @@ The following required devDependencies were not found:
   @npmcli/eslint-config
   tap
 
-To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@latest tap@latest --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
+To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@* tap@* --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
 
 -------------------------------------------------------------------
 `
@@ -250,7 +250,7 @@ The following required devDependencies were not found:
   @npmcli/eslint-config
   tap
 
-To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@latest tap@latest --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
+To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@* tap@* --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
 
 -------------------------------------------------------------------
 `
@@ -357,7 +357,7 @@ The following required devDependencies were not found:
   @npmcli/eslint-config
   tap
 
-To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@latest tap@latest --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
+To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@* tap@* --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
 
 -------------------------------------------------------------------
 
@@ -427,7 +427,7 @@ The following required devDependencies were not found:
   @npmcli/eslint-config
   tap
 
-To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@latest tap@latest --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
+To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@* tap@* --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
 
 -------------------------------------------------------------------
 
@@ -497,7 +497,7 @@ The following required devDependencies were not found:
   @npmcli/eslint-config
   tap
 
-To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@latest tap@latest --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
+To correct it: npm rm @npmcli/template-oss @npmcli/eslint-config tap && npm i @npmcli/eslint-config@* tap@* --save-dev && npm i @npmcli/template-oss@{{VERSION}} --save-dev --save-exact
 
 -------------------------------------------------------------------
 `