Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap pr title and base_ref in quotes #273

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix: wrap pr title and base_ref in quotes #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ jobs:
id: commit
continue-on-error: true
run: |
npx --offline commitlint -V --from origin/${{ github.base_ref }} --to ${{ github.event.pull_request.head.sha }}
npx --offline commitlint -V --from 'origin/${{ github.base_ref }}' --to ${{ github.event.pull_request.head.sha }}
- name: Run Commitlint on PR Title
if: steps.commit.outcome == 'failure'
run: |
echo ${{ github.event.pull_request.title }} | npx --offline commitlint -V
echo '${{ github.event.pull_request.title }}' | npx --offline commitlint -V
4 changes: 2 additions & 2 deletions lib/content/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ jobs:
id: commit
continue-on-error: true
run: |
{{ rootNpxPath }} --offline commitlint -V --from origin/$\{{ github.base_ref }} --to $\{{ github.event.pull_request.head.sha }}
{{ rootNpxPath }} --offline commitlint -V --from 'origin/$\{{ github.base_ref }}' --to $\{{ github.event.pull_request.head.sha }}
- name: Run Commitlint on PR Title
if: steps.commit.outcome == 'failure'
run: |
echo $\{{ github.event.pull_request.title }} | {{ rootNpxPath }} --offline commitlint -V
echo '$\{{ github.event.pull_request.title }}' | {{ rootNpxPath }} --offline commitlint -V
12 changes: 6 additions & 6 deletions tap-snapshots/test/apply/source-snapshots.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -744,11 +744,11 @@ jobs:
id: commit
continue-on-error: true
run: |
npx --offline commitlint -V --from origin/\${{ github.base_ref }} --to \${{ github.event.pull_request.head.sha }}
npx --offline commitlint -V --from 'origin/\${{ github.base_ref }}' --to \${{ github.event.pull_request.head.sha }}
- name: Run Commitlint on PR Title
if: steps.commit.outcome == 'failure'
run: |
echo \${{ github.event.pull_request.title }} | npx --offline commitlint -V
echo '\${{ github.event.pull_request.title }}' | npx --offline commitlint -V

.github/workflows/release.yml
========================================
Expand Down Expand Up @@ -2214,11 +2214,11 @@ jobs:
id: commit
continue-on-error: true
run: |
npx --offline commitlint -V --from origin/\${{ github.base_ref }} --to \${{ github.event.pull_request.head.sha }}
npx --offline commitlint -V --from 'origin/\${{ github.base_ref }}' --to \${{ github.event.pull_request.head.sha }}
- name: Run Commitlint on PR Title
if: steps.commit.outcome == 'failure'
run: |
echo \${{ github.event.pull_request.title }} | npx --offline commitlint -V
echo '\${{ github.event.pull_request.title }}' | npx --offline commitlint -V

.github/workflows/release.yml
========================================
Expand Down Expand Up @@ -3527,11 +3527,11 @@ jobs:
id: commit
continue-on-error: true
run: |
npx --offline commitlint -V --from origin/\${{ github.base_ref }} --to \${{ github.event.pull_request.head.sha }}
npx --offline commitlint -V --from 'origin/\${{ github.base_ref }}' --to \${{ github.event.pull_request.head.sha }}
- name: Run Commitlint on PR Title
if: steps.commit.outcome == 'failure'
run: |
echo \${{ github.event.pull_request.title }} | npx --offline commitlint -V
echo '\${{ github.event.pull_request.title }}' | npx --offline commitlint -V

.github/workflows/release.yml
========================================
Expand Down