Fix nns test with coverage #3604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
./nns_test.go:161:6: declared and not used: i Signed-off-by: Roman Khimov <roman@nspcc.ru>
It's to be updated to the final release eventually, but it's a good contract to showcase the coverage feature, quite a lot of code with good overall percentage. Signed-off-by: Roman Khimov <roman@nspcc.ru>
$ go tool cover -html=coverage.txt -o coverage.html cover: can't read "/home/rik/dev/neo-go/examples/nft-nd-nns/contract.go": open /home/rik/dev/neo-go/examples/nft-nd-nns/contract.go: no such file or directory Signed-off-by: Roman Khimov <roman@nspcc.ru>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3604 +/- ##
==========================================
- Coverage 85.27% 85.25% -0.03%
==========================================
Files 333 333
Lines 39009 39009
==========================================
- Hits 33265 33257 -8
- Misses 4177 4181 +4
- Partials 1567 1571 +4 ☔ View full report in Codecov by Sentry. |
AnnaShaleva
reviewed
Oct 9, 2024
AnnaShaleva
reviewed
Oct 9, 2024
AnnaShaleva
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.