Skip to content

Commit

Permalink
[GH-12] - Proper naming convention for tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@tpodolak
tpodolak committed Jul 13, 2018
1 parent ccc10d9 commit 0ea72a8
Show file tree
Hide file tree
Showing 17 changed files with 136 additions and 136 deletions.
16 changes: 8 additions & 8 deletions ...alyzerTests/ReEntrantReturnsSetupAnalyzerTests/ReEntrantReturnsSetupDiagnosticVerifier.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,21 @@ namespace NSubstitute.Analyzers.Tests.CSharp.DiagnosticAnalyzerTests.ReEntrantRe
{
public abstract class ReEntrantReturnsSetupDiagnosticVerifier : CSharpDiagnosticVerifier, IReEntrantReturnsSetupDiagnosticVerifier
{
public abstract Task ReturnsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall);
public abstract Task ReportsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall);

public abstract Task ReturnsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall);
public abstract Task ReportsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall);

public abstract Task ReturnsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall);
public abstract Task ReportsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall);

public abstract Task ReturnsDiagnostic_ForNestedReEntrantCall();
public abstract Task ReportsDiagnostic_ForNestedReEntrantCall();

public abstract Task ReturnsDiagnostic_ForSpecificNestedReEntrantCall();
public abstract Task ReportsDiagnostic_ForSpecificNestedReEntrantCall();

public abstract Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall);
public abstract Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall);

public abstract Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall);
public abstract Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall);

public abstract Task ReturnsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn);
public abstract Task ReportsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn);

protected override DiagnosticAnalyzer GetDiagnosticAnalyzer()
{
Expand Down
16 changes: 8 additions & 8 deletions ...agnosticAnalyzerTests/ReEntrantReturnsSetupAnalyzerTests/ReturnsAsExtensionMethodTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class ReturnsAsExtensionMethodTests : ReEntrantReturnsSetupDiagnosticVeri
[InlineData("substitute.Foo().Returns<int>(1);")]
[InlineData("SubstituteExtensions.Returns(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -86,7 +86,7 @@ private int OtherReturn()
[InlineData("substitute.Foo().ReturnsForAnyArgs<int>(1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -155,7 +155,7 @@ private int OtherReturn()
[Theory]
[InlineData("substitute.When(x => x.Foo()).Do(callInfo => { });")]
[InlineData("OtherReturn(); substitute.When(x => x.Foo()).Do(callInfo => { });")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -222,7 +222,7 @@ private int OtherReturn()
}

[Fact]
public override async Task ReturnsDiagnostic_ForNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -312,7 +312,7 @@ private int OtherNestedReturnThis()
}

[Fact]
public override async Task ReturnsDiagnostic_ForSpecificNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForSpecificNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -394,7 +394,7 @@ private int OtherNestedReturnThis()
[InlineData("MyProperty", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -468,7 +468,7 @@ Func<CallInfo, int> MyProperty
[InlineData("MyProperty", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -530,7 +530,7 @@ Func<CallInfo, int> MyProperty
[InlineData("ReturnThis", "OtherReturn")]
[InlineData("1", "2")]
[InlineData("x => 1", "x => 2")]
public override async Task ReturnsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
public override async Task ReportsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down
16 changes: 8 additions & 8 deletions ...EntrantReturnsSetupAnalyzerTests/ReturnsAsExtensionMethodWithGenericTypeSpecifiedTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class ReturnsAsExtensionMethodWithGenericTypeSpecifiedTests : ReEntrantRe
[InlineData("substitute.Foo().Returns<int>(1);")]
[InlineData("SubstituteExtensions.Returns(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -86,7 +86,7 @@ private int OtherReturn()
[InlineData("substitute.Foo().ReturnsForAnyArgs<int>(1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -155,7 +155,7 @@ private int OtherReturn()
[Theory]
[InlineData("substitute.When(x => x.Foo()).Do(callInfo => { });")]
[InlineData("OtherReturn(); substitute.When(x => x.Foo()).Do(callInfo => { });")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -221,7 +221,7 @@ private int OtherReturn()
}

[Fact]
public override async Task ReturnsDiagnostic_ForNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -311,7 +311,7 @@ private int OtherNestedReturnThis()
}

[Fact]
public override async Task ReturnsDiagnostic_ForSpecificNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForSpecificNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -393,7 +393,7 @@ private int OtherNestedReturnThis()
[InlineData("MyProperty", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -467,7 +467,7 @@ Func<CallInfo, int> MyProperty
[InlineData("MyProperty", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -529,7 +529,7 @@ Func<CallInfo, int> MyProperty
[InlineData("ReturnThis", "OtherReturn")]
[InlineData("1", "2")]
[InlineData("x => 1", "x => 2")]
public override async Task ReturnsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
public override async Task ReportsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down
16 changes: 8 additions & 8 deletions ...iagnosticAnalyzerTests/ReEntrantReturnsSetupAnalyzerTests/ReturnsAsOrdinaryMethodTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class ReturnsAsOrdinaryMethodTests : ReEntrantReturnsSetupDiagnosticVerif
[InlineData("substitute.Foo().Returns<int>(1);")]
[InlineData("SubstituteExtensions.Returns(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -86,7 +86,7 @@ private int OtherReturn()
[InlineData("substitute.Foo().ReturnsForAnyArgs<int>(1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -155,7 +155,7 @@ private int OtherReturn()
[Theory]
[InlineData("substitute.When(x => x.Foo()).Do(callInfo => { });")]
[InlineData("OtherReturn(); substitute.When(x => x.Foo()).Do(callInfo => { });")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -221,7 +221,7 @@ private int OtherReturn()
}

[Fact]
public override async Task ReturnsDiagnostic_ForNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -311,7 +311,7 @@ private int OtherNestedReturnThis()
}

[Fact]
public override async Task ReturnsDiagnostic_ForSpecificNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForSpecificNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -393,7 +393,7 @@ private int OtherNestedReturnThis()
[InlineData("MyProperty", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -467,7 +467,7 @@ Func<CallInfo, int> MyProperty
[InlineData("MyProperty", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -529,7 +529,7 @@ Func<CallInfo, int> MyProperty
[InlineData("ReturnThis", "OtherReturn")]
[InlineData("1", "2")]
[InlineData("x => 1", "x => 2")]
public override async Task ReturnsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
public override async Task ReportsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down
16 changes: 8 additions & 8 deletions ...eEntrantReturnsSetupAnalyzerTests/ReturnsAsOrdinaryMethodWithGenericTypeSpecifiedTests.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class ReturnsAsOrdinaryMethodWithGenericTypeSpecifiedTests : ReEntrantRet
[InlineData("substitute.Foo().Returns<int>(1);")]
[InlineData("SubstituteExtensions.Returns(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -86,7 +86,7 @@ private int OtherReturn()
[InlineData("substitute.Foo().ReturnsForAnyArgs<int>(1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs(substitute.Foo(), 1);")]
[InlineData("SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantReturnsForAnyArgsViaMethodCall(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -155,7 +155,7 @@ private int OtherReturn()
[Theory]
[InlineData("substitute.When(x => x.Foo()).Do(callInfo => { });")]
[InlineData("OtherReturn(); substitute.When(x => x.Foo()).Do(callInfo => { });")]
public override async Task ReturnsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
public override async Task ReportsDiagnostic_WhenUsingReEntrantWhenDo(string reEntrantCall)
{
var source = $@"using NSubstitute;
Expand Down Expand Up @@ -222,7 +222,7 @@ private int OtherReturn()
}

[Fact]
public override async Task ReturnsDiagnostic_ForNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -312,7 +312,7 @@ private int OtherNestedReturnThis()
}

[Fact]
public override async Task ReturnsDiagnostic_ForSpecificNestedReEntrantCall()
public override async Task ReportsDiagnostic_ForSpecificNestedReEntrantCall()
{
var source = @"using NSubstitute;
Expand Down Expand Up @@ -394,7 +394,7 @@ private int OtherNestedReturnThis()
[InlineData("MyProperty", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.Returns<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -468,7 +468,7 @@ Func<CallInfo, int> MyProperty
[InlineData("MyProperty", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => ReturnThis()", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
[InlineData("x => { return ReturnThis(); }", "SubstituteExtensions.ReturnsForAnyArgs<int>(substitute.Foo(), 1);")]
public override async Task ReturnsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
public override async Task ReportsNoDiagnostic_WhenRootCallCalledWithDelegate_AndReEntrantReturnsForAnyArgsCallExists(string rootCall, string reEntrantCall)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down Expand Up @@ -530,7 +530,7 @@ Func<CallInfo, int> MyProperty
[InlineData("ReturnThis", "OtherReturn")]
[InlineData("1", "2")]
[InlineData("x => 1", "x => 2")]
public override async Task ReturnsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
public override async Task ReportsNoDiagnostic_WhenReEntrantSubstituteNotUsed(string firstReturn, string secondReturn)
{
var source = $@"using NSubstitute;
using NSubstitute.Core;
Expand Down
Loading

0 comments on commit 0ea72a8

Please sign in to comment.