-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[GH-18] - vb implementation of When...Do analyzer
- Loading branch information
Showing
17 changed files
with
1,008 additions
and
160 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
114 changes: 114 additions & 0 deletions
114
src/NSubstitute.Analyzers.VisualBasic/DiagnosticAnalyzers/NonVirtualSetupWhenAnalyzer.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,114 @@ | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using Microsoft.CodeAnalysis; | ||
| using Microsoft.CodeAnalysis.Diagnostics; | ||
| using Microsoft.CodeAnalysis.VisualBasic; | ||
| using Microsoft.CodeAnalysis.VisualBasic.Syntax; | ||
| using NSubstitute.Analyzers.Shared.DiagnosticAnalyzers; | ||
|
|
||
| namespace NSubstitute.Analyzers.VisualBasic.DiagnosticAnalyzers | ||
| { | ||
| [DiagnosticAnalyzer(LanguageNames.VisualBasic)] | ||
| internal class NonVirtualSetupWhenAnalyzer : AbstractNonVirtualWhenAnalyzer<SyntaxKind, InvocationExpressionSyntax> | ||
| { | ||
| public NonVirtualSetupWhenAnalyzer() | ||
| : base(new DiagnosticDescriptorsProvider()) | ||
| { | ||
| } | ||
|
|
||
| protected override SyntaxKind InvocationExpressionKind { get; } = SyntaxKind.InvocationExpression; | ||
|
|
||
| protected override IEnumerable<SyntaxNode> GetExpressionsForAnalysys(SyntaxNodeAnalysisContext syntaxNodeAnalysisContext, IMethodSymbol methodSymbol, InvocationExpressionSyntax invocationExpressionSyntax) | ||
| { | ||
| var argumentListArguments = invocationExpressionSyntax.ArgumentList.Arguments; | ||
| var argumentSyntax = methodSymbol.MethodKind == MethodKind.ReducedExtension ? argumentListArguments.First() : argumentListArguments.Skip(1).First(); | ||
| return GetExpressionsForAnalysys(syntaxNodeAnalysisContext, argumentSyntax.GetExpression()); | ||
| } | ||
|
|
||
| private IEnumerable<SyntaxNode> GetExpressionsForAnalysys(SyntaxNodeAnalysisContext syntaxNodeContext, SyntaxNode syntax) | ||
| { | ||
| SyntaxNode body = null; | ||
| switch (syntax) | ||
| { | ||
| case SingleLineLambdaExpressionSyntax _: | ||
| case ExpressionStatementSyntax _: | ||
| case LocalDeclarationStatementSyntax _: | ||
| case AssignmentStatementSyntax _: | ||
| body = syntax; | ||
| break; | ||
| case MultiLineLambdaExpressionSyntax simpleLambdaExpressionSyntax: | ||
| foreach (var syntaxNode in IterateStatements(simpleLambdaExpressionSyntax.Statements)) | ||
| { | ||
| yield return syntaxNode; | ||
| } | ||
|
|
||
| break; | ||
| case MethodBlockSyntax methodBlockSyntax: | ||
| foreach (var syntaxNode in IterateStatements(methodBlockSyntax.Statements)) | ||
| { | ||
| yield return syntaxNode; | ||
| } | ||
|
|
||
| break; | ||
| case UnaryExpressionSyntax unaryExpressionSyntax: | ||
| foreach (var syntaxNode in GetExpressionsForAnalysys(syntaxNodeContext, unaryExpressionSyntax.Operand)) | ||
| { | ||
| yield return syntaxNode; | ||
| } | ||
|
|
||
| break; | ||
| case IdentifierNameSyntax identifierNameSyntax: | ||
| var symbol = syntaxNodeContext.SemanticModel.GetSymbolInfo(identifierNameSyntax); | ||
| if (symbol.Symbol != null && symbol.Symbol.Locations.Any()) | ||
| { | ||
| var location = symbol.Symbol.Locations.First(); | ||
| var syntaxNode = location.SourceTree.GetRoot().FindNode(location.SourceSpan); | ||
|
|
||
| SyntaxNode innerNode = null; | ||
| if (syntaxNode is MethodStatementSyntax methodStatementSyntax) | ||
| { | ||
| innerNode = methodStatementSyntax.Parent; | ||
| } | ||
|
|
||
| innerNode = innerNode ?? syntaxNode; | ||
| foreach (var expressionsForAnalysy in GetExpressionsForAnalysys(syntaxNodeContext, innerNode)) | ||
| { | ||
| yield return expressionsForAnalysy; | ||
| } | ||
| } | ||
|
|
||
| break; | ||
| } | ||
|
|
||
| if (body == null) | ||
| { | ||
| yield break; | ||
| } | ||
|
|
||
| var memberAccessExpressions = body.DescendantNodes().Where(node => node.IsKind(SyntaxKind.SimpleMemberAccessExpression)); | ||
| var invocationExpressions = body.DescendantNodes().Where(node => node.IsKind(SyntaxKind.InvocationExpression)); | ||
|
|
||
| // rather ugly but prevents reporting two times the same thing | ||
| // as VB syntax is based on statements, you can't access body of method directly | ||
| if (invocationExpressions.Any()) | ||
| { | ||
| foreach (var invocationExpression in invocationExpressions) | ||
| { | ||
| yield return invocationExpression; | ||
| } | ||
| } | ||
| else if (memberAccessExpressions.Any()) | ||
| { | ||
| foreach (var memberAccessExpression in memberAccessExpressions) | ||
| { | ||
| yield return memberAccessExpression; | ||
| } | ||
| } | ||
|
|
||
| IEnumerable<SyntaxNode> IterateStatements(IEnumerable<StatementSyntax> statements) | ||
| { | ||
| return statements.SelectMany(statement => GetExpressionsForAnalysys(syntaxNodeContext, statement)); | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 changes: 30 additions & 3 deletions
33
src/NSubstitute.Analyzers.VisualBasic/Resources.Designer.cs
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.