[GH-135] - Detecting received like methods used in Received.InOrder

[tpodolak]

Closes #135

[coveralls]

Pull Request Test Coverage Report for Build 377

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.3%) to 95.553%

---

Files with Coverage Reduction	New Missed Lines	%
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.Shared/Extensions/SubstituteSymbolExtensions.cs	2	92.0%

Totals
Change from base Build 372:	0.3%
Covered Lines:	2213
Relevant Lines:	2316

---

💛 - Coveralls

[tpodolak]

@dtchepak as discussed nsubstitute/NSubstitute#604 (comment)
feel free to suggest better documentation and diagnostic id

[dtchepak]

Some minor doc suggestions. Happy to merge as is. 👍

[dtchepak]

sub.Bar(); (one .)

[tpodolak]

fixed

[dtchepak]

My suggestion:

A violation of this rule occurs when any of the following are used inside Received.InOrder callback:

• Received()
• ReceivedWithAnyArgs()
• DidNotReceive()
• DidNotReceiveWithAnyArgs()

Calls within Received.InOrder are already checked to ensure they were received in the expected order. Individual received-like assertions should be moved outside the Received.InOrder block.

[tpodolak]

fixed

[dtchepak]

Should this be 3 ticks instead of 4? "```"? Never mind, just saw this renders fine with 4. I've just always used 3 😂

[dtchepak]

Alternatively, move the received-like method outside of Received.InOrder block:

// Incorrect:
Received.InOrder(() =>
{
    sub.Baz();
    sub.DidNotReceive().Bar();
})

// Correct:
Received.InOrder(() =>
{
    sub.Baz();
})
sub.DidNotReceive().Bar();

[dtchepak]

I aggregated these here: #135 (comment)

[tpodolak]

Thanks, copy-pasted your version