Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 138 introduce substitute #141

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Gh 138 introduce substitute #141

merged 1 commit into from
Mar 24, 2020

Conversation

tpodolak
Copy link
Member

Closes #138
Introduce substitute refactoring for c#
introducesubstitute
and VB
visualbasic

@dtchepak please take a look if menu titles looks good to you. Not sure how to document this feature in the docs, any thoughts?

@tpodolak tpodolak force-pushed the GH-138-introduce-substitute branch from d22dff9 to e80be3a Compare March 22, 2020 18:00
@coveralls
Copy link

coveralls commented Mar 22, 2020

Pull Request Test Coverage Report for Build 390

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 95.833%

Totals Coverage Status
Change from base Build 387: 0.2%
Covered Lines: 2438
Relevant Lines: 2544

💛 - Coveralls

Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I can't think of better titles for the refactorings. I was thinking of things like:

Introduce substitutes for missing arguments as readonly fields
Introduce substitutes for missing arguments as local variables
Introduce substitute for {substituteName} as local variable
Introduce substitute for {substituteName} as readonly field

But I think these seem too long. I think people will quickly learn what the current, concise titles mean. WDYT?

For documentation, I think a short summary is enough? Maybe the screen capture is good to add too, I think that is a very good illustration of the feature.

In https://github.com/nsubstitute/NSubstitute.Analyzers/tree/dev/documentation:

### Code refactoring

#### Introduce substitute

Automatically create substitutes for constructor arguments as fields or local variables.

<<screen capture>>

@tpodolak tpodolak force-pushed the GH-138-introduce-substitute branch from e80be3a to 38fae8d Compare March 24, 2020 00:12
@tpodolak
Copy link
Member Author

Looks great!

I can't think of better titles for the refactorings. I was thinking of things like:

Introduce substitutes for missing arguments as readonly fields
Introduce substitutes for missing arguments as local variables
Introduce substitute for {substituteName} as local variable
Introduce substitute for {substituteName} as readonly field

But I think these seem too long. I think people will quickly learn what the current, concise titles mean. WDYT?

For documentation, I think a short summary is enough? Maybe the screen capture is good to add too, I think that is a very good illustration of the feature.

In https://github.com/nsubstitute/NSubstitute.Analyzers/tree/dev/documentation:

### Code refactoring

#### Introduce substitute

Automatically create substitutes for constructor arguments as fields or local variables.

<<screen capture>>

@dtchepak I decided to leave existing menu titles. In case this causes confusion we can always change them as this is non-breaking change. The docs were updated as well, take a look if it looks ok for you

Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to leave existing menu titles.

I think this is a good decision.

The docs were updated as well, take a look if it looks ok for you

Looks good to me 👍

@tpodolak tpodolak merged commit 1108c34 into dev Mar 24, 2020
@tpodolak tpodolak deleted the GH-138-introduce-substitute branch March 24, 2020 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quick-action for introducing fake in constructor argument
3 participants