-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gh 138 introduce substitute #141
Conversation
d22dff9
to
e80be3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I can't think of better titles for the refactorings. I was thinking of things like:
Introduce substitutes for missing arguments as readonly fields
Introduce substitutes for missing arguments as local variables
Introduce substitute for {substituteName} as local variable
Introduce substitute for {substituteName} as readonly field
But I think these seem too long. I think people will quickly learn what the current, concise titles mean. WDYT?
For documentation, I think a short summary is enough? Maybe the screen capture is good to add too, I think that is a very good illustration of the feature.
In https://github.com/nsubstitute/NSubstitute.Analyzers/tree/dev/documentation:
### Code refactoring
#### Introduce substitute
Automatically create substitutes for constructor arguments as fields or local variables.
<<screen capture>>
e80be3a
to
38fae8d
Compare
@dtchepak I decided to leave existing menu titles. In case this causes confusion we can always change them as this is non-breaking change. The docs were updated as well, take a look if it looks ok for you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I decided to leave existing menu titles.
I think this is a good decision.
The docs were updated as well, take a look if it looks ok for you
Looks good to me 👍
Closes #138
Introduce substitute refactoring for c#
and VB
@dtchepak please take a look if menu titles looks good to you. Not sure how to document this feature in the docs, any thoughts?