Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-162 - analyzing all params arguments #168

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Conversation

tpodolak
Copy link
Member

@tpodolak tpodolak commented Sep 5, 2021

Improvements for #162

@dtchepak initial fix for #162 was not validating all params elements, so invalid cases like this

var substitute = NSubstitute.Substitute.For<Foo>(new object[] { 1, 1m });

were not detected. This PR aims to fix that problem

@coveralls
Copy link

Pull Request Test Coverage Report for Build 436

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 95.561%

Files with Coverage Reduction New Missed Lines %
C/projects/nsubstitute-analyzers/src/NSubstitute.Analyzers.Shared/DiagnosticAnalyzers/AbstractSubstituteConstructorMatcher.cs 1 97.78%
Totals Coverage Status
Change from base Build 435: -0.003%
Covered Lines: 2519
Relevant Lines: 2636

💛 - Coveralls

@tpodolak tpodolak merged commit 6587b6e into dev Oct 10, 2021
@tpodolak tpodolak deleted the GH-162-improvements branch October 10, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants