Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change TargetFramework from netstandard1.3 to netstandard2.0 #198

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Change TargetFramework from netstandard1.3 to netstandard2.0 #198

merged 2 commits into from
Jan 31, 2023

Conversation

bdovaz
Copy link
Contributor

@bdovaz bdovaz commented Jan 22, 2023

Resolves #197

@bdovaz
Copy link
Contributor Author

bdovaz commented Jan 22, 2023

I had to remove the PackageTargetFallback property because it is deprecated and caused the build to fail:

image

@coveralls
Copy link

Pull Request Test Coverage Report for Build 522

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.109%
Totals Coverage Status
Change from base Build 520: 0.0%
Covered Lines: 2654
Relevant Lines: 2733
💛 - Coveralls

@alexandrnikitin alexandrnikitin mentioned this pull request Jan 25, 2023
Merged
@tpodolak tpodolak merged commit dd458f1 into nsubstitute:dev Jan 31, 2023
@bdovaz bdovaz deleted the feature/net-standard-20 branch February 1, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpodolak tpodolak tpodolak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add .netstandard2.0 target to NSubstitute.Analyzers.CSharp
3 participants
@bdovaz @coveralls @tpodolak