Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 30 call info analyzer #33

Merged
merged 19 commits into from
Sep 5, 2018
Merged

Gh 30 call info analyzer #33

merged 19 commits into from
Sep 5, 2018

Conversation

tpodolak
Copy link
Member

Closes #30

@tpodolak
[GH-30] - scaffolding
9300e00
@tpodolak
[GH-30] - basic arg analyzer
a5302a3
@tpodolak
[GH-30] - trying to extract abstraction layer
036d63d
@tpodolak
[GH-30] - refactoring
03badcf
@tpodolak
[GH-30] - Visual Basic implementation
5d484b5
@tpodolak
[GH-30] - First fully flagged test for VB
d188f6d
@tpodolak
[GH-30] - additional tests for Visual Basic implementation
0cb651d
@tpodolak
[GH-30] - full suit of csharp tests for returns method
d55cd2f
@tpodolak
[GH-30] - detecting callinfos on indexers and properties
b50450a
@tpodolak
[GH-30] - VisualBasic indexer handling nad tests
d3da9c6
@tpodolak
[GH-30] - Returns like methods tests
cb6974e
@tpodolak
[GH-30] - Additional set of tests for csharp CallInfoAnalyzer
887b494
@tpodolak
[GH-30] - visual basic implementation tests
41e9135
@tpodolak
[GH-30] - small refactoring
466087e
@tpodolak
[GH-30] - better conversion checks
3aa0ab1
@tpodolak
[GH-30] - proper detection of casts for Arg and indexer usages
9e380af
@tpodolak
[GH-30] - additional set of tests for getting position of argument
0804465
@tpodolak
[GH-30] - tests for indirect substitute calls
9e79430
@tpodolak
Merge branch 'dev' of https://github.com/nsubstitute/NSubstitute.Anal…
1ba06e5 
…yzers into GH-30-Call-Info-Analyzer
@coveralls
Copy link

Pull Request Test Coverage Report for Build pc6jvryfri5oacdr

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 96.975%
Totals Coverage Status
Change from base Build toex6uigtlgjr3hi: 0.6%
Covered Lines: 1026
Relevant Lines: 1058
💛 - Coveralls

dtchepak
dtchepak approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

The Roslyn stuff is still mysterious magic for me, so I'm probably not going to be able to provide much more than a sanity check for these. If there's anything in particular you want feedback on in terms of design please let me know in the PR description so I can focus on those parts. :)

@tpodolak
Copy link
Member Author

Hi @dtchepak I think that as usual, I would need a feedback about diagnostic messages presented to the users - I took all of the messages from NSubstitute exceptions but maybe we can do better. Additionally, if you know any other misusages of callInfo let me know so I can extend the logic of analyzer. When it comes to design, this analyzer is a bit complex so if you see any way to simplify/refactor feel free to ping me

@tpodolak tpodolak merged commit 8e92a14 into dev Sep 5, 2018
@tpodolak tpodolak deleted the GH-30-Call-Info-Analyzer branch September 5, 2018 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpodolak @coveralls @dtchepak