Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gh 40 group diagnostics into categories #41

Merged
merged 3 commits into from
Oct 7, 2018
Merged

Gh 40 group diagnostics into categories #41

merged 3 commits into from
Oct 7, 2018

Conversation

tpodolak
Copy link
Member

@tpodolak tpodolak commented Oct 5, 2018 •
edited
Loading

Closes #40

@coveralls
Copy link

coveralls commented Oct 5, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build afwt3pv9aqxsfwdf

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 96.768%
Totals Coverage Status
Change from base Build 22hen4yd5nc3b818: -0.04%
Covered Lines: 1048
Relevant Lines: 1083
💛 - Coveralls

dtchepak
dtchepak approved these changes Oct 6, 2018
View reviewed changes
Copy link
Member

@dtchepak dtchepak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about whether to use string interpolation in the test definitions referencing NS1000.

Happy to have this merged in with or without this change. (whatever you prefer)

...ressDiagnosticsCodeFixProviderTests/NonVirtualSetupSuppressDiagnosticsCodeFixActionsTests.cs Outdated Show resolved Hide resolved
@tpodolak tpodolak merged commit 7ea03f0 into dev Oct 7, 2018
@tpodolak tpodolak deleted the GH-40-group-diagnostics branch January 31, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtchepak dtchepak dtchepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpodolak @coveralls @dtchepak