Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It's a library #545

Merged
merged 1 commit into from
Apr 17, 2019
Merged

It's a library #545

merged 1 commit into from
Apr 17, 2019

Conversation

dtchepak
Copy link
Member

Not a framework. 😄

Tackling the big issues here. 😂

Not a framework. :)
@dtchepak dtchepak requested a review from zvirja April 17, 2019 00:21
@zvirja
Copy link
Contributor

zvirja commented Apr 17, 2019

@dtchepak What's wrong with you man, why are you lowering in rank our great tool? 😢 It's awesome enough to be even beyond the "framework" definition!!1

That was a joke. Ha Ha.

If you believe that library suits better, then go ahead and change it.

BTW, I noticed that Moq and FakeItEasy seem to be confused about their title:

image

image

image

Just out of curiosity, @stakx @blairconrad do you consider your product being a library, or a framework? 😉

@stakx
Copy link

stakx commented Apr 17, 2019

@zvirja: In my eyes, Moq is clearly a library, as it leaves its user / client code in the driver's seat. It expects to be called by user code, and not the other way around.

Thanks for the cue, guys, I'll follow your example and clean up Moq's description. 😉

@blairconrad
Copy link

I'm not sure it's a big deal, really. But had I to choose, "library". As @stakx, our clients call it, not the other way around. I'd have no objection to rewording the description, but what to do about our twitter handle and Gmail account?!?!

/cc @thomaslevesque

@thomaslevesque
Copy link

I'm not sure it's a big deal, really. But had I to choose, "library". As @stakx, our clients call it, not the other way around. I'd have no objection to rewording the description, but what to do about our twitter handle and Gmail account?!?!

I'd say "library" too, for the reasons already mentioned. I remember seeing "framework" in the description and being vaguely bothered by it, but then it completely slipped my mind. I think we should change it. Too bad about the Twitter handle, I guess we'll have to live with it...

@dtchepak dtchepak added the bug Reported problem with NSubstitute behaviour label Apr 17, 2019
@dtchepak
Copy link
Member Author

Thanks for everyone's contributions -- it's great to see .NET mocking framework library authors working together for the common good! ❤️

@blairconrad @thomaslevesque The Twitter handle is perfect! The "fx" is for "effects", like special effects in movies. It's a library that brings magical effects to .NET mocking! ✨👍

@zvirja This will require a major version bump to comply with semver?

PS: On a more serious note, thanks for the work you all put in to encourage testing for the .NET platform. I'm a big fan of Moq and FIE. Keep up the great work! ❤️👍

@zvirja
Copy link
Contributor

zvirja commented Apr 17, 2019

@zvirja This will require a major version bump to comply with semver?

I think bumping major will be not enough - we should publish a brand new product now 😅

P.S. If you are speaking seriously then of course not, we are following SemVer for API only.

@dtchepak
Copy link
Member Author

@zvirja No of course I'm not serious about a major version bump! I know that this sort of change requires a new product! 😅

I'm thinking OSubstitute ('O' > 'N').

@dtchepak dtchepak merged commit ae57666 into nsubstitute:master Apr 17, 2019
@dtchepak dtchepak deleted the its-not-a-framework branch April 17, 2019 13:22
@blairconrad
Copy link

From @dtchepak:

It's a library that brings magical effects to .NET mocking! ✨ 👍

I think we have a new quote to add to the top of the testimonials page!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Reported problem with NSubstitute behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants