Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PROJECT file is not updated with component workloads #49

Closed
scottd018 opened this issue Jul 13, 2022 · 0 comments
Closed

fix: PROJECT file is not updated with component workloads #49

scottd018 opened this issue Jul 13, 2022 · 0 comments
Assignees

Comments

@scottd018
Copy link
Contributor

This specifically applies to a collection. Standalone workloads are added just fine and any followon workloads are added fine as well. Given the following PROJECT file in the root:

domain: mydomain.com
layout:
- go.kubebuilder.io/v3
multigroup: true
plugins:
  operatorBuilder:
    cliRootCommandName: opctl
    controllerImg: ""
    workloadConfigPath: .operator-builder/workload.yaml
projectName: myoperator
repo: github.com/myproject/myoperator
resources:
- api:
    crdVersion: v1
    namespaced: true
  controller: true
  domain: mydomain.com
  group: custom
  kind: MyResource
  path: github.com/myproject/myoperator/apis/custom/v1alpha1
  version: v1alpha1
  webhooks:
    conversion: true
    defaulting: true
    validation: true
    webhookVersion: v1

When using a collection, only the top-level collection is added. The components should also exist in this file. This helps when we get to the point where we need to create webhooks, as the create webhook command needs to know about the project metadata.

@scottd018 scottd018 changed the title fix: PROJECT file is not updated with all resources fix: PROJECT file is not updated with component workloads Jul 13, 2022
@scottd018 scottd018 self-assigned this Jul 22, 2022
lander2k2 added a commit that referenced this issue Jul 25, 2022
fix: Fixes #49, inject resource info to update PROJECT file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant