Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minor updates and fixes #34

Merged
merged 3 commits into from
Jun 14, 2022
Merged

feat: minor updates and fixes #34

merged 3 commits into from
Jun 14, 2022

Conversation

scottd018
Copy link
Contributor

This PR addresses 2 issues:

  1. usage of integers in replace - converts the integer to a rune and a string so that it may be used as a string
  2. usage of parent metadata.name field - uses format operator-builder:field:parent=metadata.name. field for parent is restricted to metadata.name only.

@scottd018
fix: Fixes #32, added support for integer replacement
43f02c5 
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
@scottd018
fix: Fixes #18, added ability to use parent resource name in child re…
dc098a7 
…source

Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
@scottd018
chore: fix linter errors
0117786 
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
@lander2k2 lander2k2 merged commit 8fbdd79 into main Jun 14, 2022
@lander2k2 lander2k2 deleted the minor-updates branch June 14, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scottd018 @lander2k2