fix: add event markers and update go version #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed when we recently added changes to add events to deployed resources. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
Because a future version of go (e.g. go 1.23) is not out yet, we are on the latest version. For the operator-builder binary, we are not dependent on layered go versions (e.g. generated code go versions) so we have more flexibility in version selection. Removed the multiple array selection, but left it as an array in case we want to test future versions when they release, or multiple versions for whatever the case may be. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
…rsion This is because the go binary can be built on different versions than the codebase itself. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
lander2k2
requested changes
May 1, 2024
go.mod
Outdated
| @@ -1,15 +1,15 @@ | |||
| module github.com/nukleros/operator-builder | |||
|
|
|||
| go 1.18 | |||
| go 1.21 | |||
There was a problem hiding this comment.
This should be version 1.22 right?
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
This is because we were duplicating the operator-builder build in the pipeline. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
lander2k2
approved these changes
May 22, 2024
scottd018
added a commit
to scottd018/operator-builder
that referenced
this pull request
Jul 3, 2024
* fix: added missing events marker This was missed when we recently added changes to add events to deployed resources. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * feat: switch to gener8s over legacy ocgk package Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * fix: enforce go 1.22 Because a future version of go (e.g. go 1.23) is not out yet, we are on the latest version. For the operator-builder binary, we are not dependent on layered go versions (e.g. generated code go versions) so we have more flexibility in version selection. Removed the multiple array selection, but left it as an array in case we want to test future versions when they release, or multiple versions for whatever the case may be. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * test: add ability to use different binary versions versus codebase version This is because the go binary can be built on different versions than the codebase itself. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * feat: use 1.22 in go mod Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * feat: add toolchain for dealing with lower go versions Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * test: add flag to prevent binary builds when requested This is because we were duplicating the operator-builder build in the pipeline. Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * docs: update go version in docs Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * ci: update kind and kubectl versions in pipeline Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> * ci: update goreleaser and remove deprecated fields Signed-off-by: Dustin Scott <dustin.scott18@gmail.com> --------- Signed-off-by: Dustin Scott <dustin.scott18@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following updates: