Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLD: unvendor meson-python #25008

Merged
merged 4 commits into from
Oct 26, 2023
Merged

BLD: unvendor meson-python #25008

merged 4 commits into from
Oct 26, 2023

Conversation

rgommers
Copy link
Member

The meson-python 0.15.0 release added the ability to configure a custom meson in pyproject.toml. So there's no longer a need for us to vendor it.

@rgommers rgommers added this to the 2.0.0 release milestone Oct 26, 2023
@github-actions github-actions bot added the 36 - Build Build related PR label Oct 26, 2023
@rgommers
Copy link
Member Author

Python 3.12 failures:

  meson.build:40:22: ERROR: <PythonExternalProgram 'python3' -> ['/opt/hostedtoolcache/Python/3.12.0/x64/bin/python']> is not a valid python or it is missing distutils

The vendored Meson needs an update so that we're getting the fixes in Meson 1.2.3 to avoid distutils/setuptools completely.

The meson-python 0.15.0 release added the ability to configure a
custom `meson` in `pyproject.toml`. So there's no longer a need for
us to vendor it.
@rgommers
Copy link
Member Author

Almost victory - a single test error left in the "without optimizations" job of linux_simd.yml:

  ----------------------------- Captured stderr call -----------------------------
  Traceback (most recent call last):
    File "/tmp/pytest-of-runner/pytest-0/test_limited_api0/limited_api/setup.py", line 6, in <module>
      from setuptools import setup, Extension
  ModuleNotFoundError: No module named 'setuptools'
  =========================== short test summary info ============================
  FAILED numpy/_core/tests/test_limited_api.py::test_limited_api - subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.12.0/x64/bin/python', 'setup.py', 'build', 'install', '--prefix', '/tmp/pytest-of-runner/pytest-0/test_limited_api0/installdir', '--single-version-externally-managed', '--record', '/tmp/pytest-of-runner/pytest-0/test_limited_api0/tmp_install_log.txt']' returned non-zero exit status 1.

That's because on 3.12 we no longer install setuptools as a build dependency, and it's needed as a test dependency there. Should be fixed by the last commit.

@rgommers
Copy link
Member Author

Victory! This is ready to merge.

@charris charris merged commit 450f330 into numpy:main Oct 26, 2023
55 checks passed
@charris
Copy link
Member

charris commented Oct 26, 2023

Thanks Ralf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants