Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Console-Command-Line.md #982

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

CharliePoole
Copy link
Contributor

Reflects changes made to the console runner help message in response to nunit/nunit-console#1359. Users are confused about the distinction between command-line arguments and the arguments passed to the runner.

Reflects changes made to the console runner help message in response to nunit/nunit-console#1359. Users are confused about the distinction between command-line arguments and the arguments passed to the runner.
@CharliePoole
Copy link
Contributor Author

@SeanKilleen As you probably know I'm helping out on the console runner once more. I fixed a documentation bug regarding something that was confusing to the users in the docs as well as completely missing in the --help message. My PR to the docs project is failing in ways I don't understand but which seem to have nothing to do with my own changes.

If I'm wrong about that, please let me know. Otherwise, can you merge the change I made to a single paragraph?

TIA, Charlie

@SeanKilleen
Copy link
Member

Hi @CharliePoole! Always great to cross paths with you. :)

Sorry about the inconvenience on the docs side. This is related to an issue that I hadn't specifically written up a GH issue for yet, but have just done so: #983

In short, this PR is fine, it is only failing to deploy a Netlify preview, for reasons unrelated to your PR.

This PR is good to merge, and I will do so now.

@SeanKilleen SeanKilleen merged commit 697dcef into nunit:master Sep 19, 2024
6 of 7 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 19, 2024
Reflects changes made to the console runner help message in response to nunit/nunit-console#1359. Users are confused about the distinction between command-line arguments and the arguments passed to the runner. 697dcef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants