Disable new MSBuild GenerateSupportedRuntime functionality, which breaks framework targetting #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SDK bug report here: dotnet/sdk#3036 Azure build failed on restoring the Linux NuGet packages...rerunning... |
rprouse
approved these changes
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a recent change to MSBuild (dotnet/sdk#2447) which had the effect of preventing the NUnit console from running any .NET 4.0+ test assemblies.
The MSBuild change automatically inserted
supportedRuntimetags into the app.config, when there were none. This overrode thecomplus_versionenvironment variable, which the console uses to ensure that the agent process is launched on the correct .NET Framework version to run each test assembly.The new MSBuild functionality (GenerateSupportedRuntimes) caused the agent to always launch under .NET 2.0. This prevented the NUnit running any assemblies above .NET 4.0. Adding these two lines to the agent csproj's prevents this behaviour from taking place, which is currently required if we wish to continue targeting specific .NET Framework versions through
complus_version. (The real solution may be to stop doing that undocumented solution however - I'm not sure what other solutions there are)dotnet/sdk bug report also incoming, will link back