Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation to LinearBoundary stages #418

Merged
5 commits merged into from
Nov 8, 2022
Merged

Add documentation to LinearBoundary stages #418

5 commits merged into from
Nov 8, 2022

Conversation

drobison00
Copy link
Contributor

Resolves #413

@drobison00 drobison00 requested a review from a team as a code owner October 26, 2022 19:09
@drobison00 drobison00 added non-breaking Non-breaking change doc Improvements or additions to documentation improvement Improvement to existing functionality 3 - Ready for Review and removed improvement Improvement to existing functionality labels Oct 26, 2022
mdemoret-nv
mdemoret-nv requested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think we need to add a docstring to LinearPipeline.add_segment_boundary() as well since thats the interface most users will use to interact with the segments at first.

morpheus/stages/boundary/linear_boundary_stage.py Outdated Show resolved Hide resolved
morpheus/stages/boundary/linear_boundary_stage.py Show resolved Hide resolved
morpheus/stages/boundary/linear_boundary_stage.py Show resolved Hide resolved
drobison00 and others added 2 commits November 3, 2022 15:01
@drobison00 @mdemoret-nv
Update morpheus/stages/boundary/linear_boundary_stage.py
3f34d43 
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
@drobison00
Add Examples for LinearPipeline.add_segment_boundary()
efac620
@drobison00
Copy link
Contributor Author

@mdemoret-nv Updated based on your most recent comments.

mdemoret-nv
mdemoret-nv approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one fix then it looks good.

morpheus/pipeline/linear_pipeline.py Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 00124d1 into nv-morpheus:branch-22.11 Nov 8, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC]: Update LinearBoundaryStage Documentation
2 participants
@drobison00 @mdemoret-nv