Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorganize init.lua to a multi file setup #473

Closed
wants to merge 9 commits into from

Conversation

dam9000
Copy link
Contributor

@dam9000 dam9000 commented Oct 22, 2023

I understand the kickstart init.lua is single-file by design, and most likely this PR will not be accepted and that's fine. I just think a multi-file approach is better, even for beginners. In any case thanks for the kickstart.nvim it is the best starting point for nvim configuration.

@feoh
Copy link
Collaborator

feoh commented Oct 22, 2023

Hi there!

First off, thanks for your contribution! The beauty of open source is that there's no harm in submitting a PR.

As you say, the nature of this particular project is that it's largely a single file. One file to read. One file to understand.

Would you consider starting a fork? That way you could maintain whatever organization makes sense for you, and folks can use your fork instead who want a multiple file approach.

As always I welcome community input. If folks feel very strongly that a multiple file approach makes more sense, then please chime in here. If enough people feel this way we can re-open and reconsider this PR, but I'm closing it for now.

@feoh feoh closed this Oct 22, 2023
@dam9000
Copy link
Contributor Author

dam9000 commented Oct 22, 2023

@feoh thanks for the feedback.
Regarding the fork, yes, my multi-file kickstart fork is here:
https://github.com/dam9000/kickstart-modular.nvim

@WindSoilder
Copy link

As you say, the nature of this particular project is that it's largely a single file. One file to read. One file to understand

This is what makes me find it usable, I've tried to use neovim many times, but only this one helps me dive into the world of neovim.
It's a single file, it's best for new-bee who doesn't have any neovim experience.

@feoh
Copy link
Collaborator

feoh commented Oct 23, 2023

@dam9000 That's fantastic! With your approval I'll add a note to the README for folks who might prefer a multi-file approach so they can more easily find your project.

@dam9000
Copy link
Contributor Author

dam9000 commented Oct 23, 2023

@feoh Sure, of course I approve and welcome if you can add a link to my multi-file fork to the README. And I'll try to do my best to keep it up to date with all the upstream changes, while making no other functional changes.

@greg-nagy
Copy link

I know that maintaining oss projects is hard

so I am here to thank you all for both the single file kickstart, the modular kickstart and the starter

as someone new to neovim I find all of them very helpful and a good augmentation for my learning as I get into the weeds

appreciate y'all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants