Windows: download's promise fires early

[adam-lynch]

I've a valid ZIP at a valid URL and the download callback gets called almost instantly. The download just ends at 0 KB. Any ideas @edjafarov?

[edjafarov]

is this a test? or real life app?

[edjafarov]

try https://github.com/edjafarov/node-webkit-updater/blob/master/app/updater.js#L80 put on('data') to see what are you getting. And check temp dir. My guess it might make sense to clean up previous zip.

[adam-lynch]

Real use case. I'll try that. Maybe we need an .on('error') too. There's no previous ZIP in that location so that wasn't the problem anyway.

[adam-lynch]

It was that I wasn't passing the new manifest to download so it used the original manifest which pointed to URLs which didn't exist. request doesn't throw an error for 404s, etc. it's up to us to check for it. Fixed.