Custom header fields in NXOAuth2Request #132
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +61,7 @@ - (NSString *)nxoauth2_URLEncodedString; | |||
| return (__bridge_transfer NSString *) CFURLCreateStringByAddingPercentEscapes(kCFAllocatorDefault, //Allocator | |||
| (__bridge CFStringRef)self, //Original String | |||
| NULL, //Characters to leave unescaped | |||
| CFSTR("!*'();:@&=+$,/?%#[]"), //Legal Characters to be escaped | |||
| NULL, //CFSTR("!*'();:@&=+$,/?%#[]"), //Legal Characters to be escaped | |||
There was a problem hiding this comment.
Please do not leave in commented out code. If you think this should be removed do so, otherwise remove the comment.
|
What's happening for this pull request? For example, when requesting token I need content type set to: application/x-www-form-urlencoded and it looks like this PR fixes a few more issues. |
|
Did you fix the things I commented on? |
|
Why this pr is not merged?? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for custom header fields when using the NXOAuth2Request class