Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 64 bits warnings #137

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

damienrambout
Copy link

  • I updated the project settings to remove a warning in Xcode 6.
  • I used NSInteger or NSUInteger where required to avoid conversion with precision loss (warnings)
  • I replaced several integer format keys (mainly in asserts) with object format keys so that no warning shows up in future SDK releases

@@ -53,7 +53,6 @@
942FFD7E12315EFF00E6C65E /* Security.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = 94E5AC92122C097B00C7021A /* Security.framework */; };
945A500D123F7BAE00A6F2EB /* NXOAuth2ClientDelegate.h in Headers */ = {isa = PBXBuildFile; fileRef = 824D5A6D123F68A8001177D5 /* NXOAuth2ClientDelegate.h */; settings = {ATTRIBUTES = (Public, ); }; };
94B6CE7219C1D3E400AA859B /* NXOAuth2PostBodyStreamSpec.m in Sources */ = {isa = PBXBuildFile; fileRef = 94B6CE7119C1D3E400AA859B /* NXOAuth2PostBodyStreamSpec.m */; };
94B6CE8119C1EECC00AA859B /* Info.plist in Resources */ = {isa = PBXBuildFile; fileRef = 94B6CE8019C1EECC00AA859B /* Info.plist */; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you removed the Info.plist here?

@damienrambout
Copy link
Author

I'm super late, but I fixed what was wrong based on your remarks. I don't know why the Info.plist file disappeared from the pbxproj file.

@damienrambout
Copy link
Author

Please merge or reject as fast as you can because I'd like to make another pull request on a completely other subject. (But I can't make 2 forks of the same repo)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants