Fix dropped 401 response when token present #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a 401 response comes back to a request made with a token, if the WWW-Authenticate header does not contain the keywords "invalid_token" or "expired_token", the connection will get dropped silently because `- requestAccessAndRetryConnection:` expects no tokens. This fix adds an extra condition to ensure that it doesn't attempt to request access when the OAuth2Client's access token is present. The connection won't get dropped and the response handler will be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a 401 response comes back to a request made with a token, if the
WWW-Authenticateheader does not contain the keywordsinvalid_tokenorexpired_token, the connection will get dropped silently because- requestAccessAndRetryConnection:expects no tokens.This fix adds an extra condition to ensure that it doesn't attempt to request access when the OAuth2Client's access token is present. The connection won't get dropped and the response handler will be called.