Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC to integrate OpenSearch as the third search engine #559

Merged
merged 8 commits into from
Sep 20, 2022
Merged

Conversation

mkr
Copy link
Contributor

@mkr mkr commented Sep 14, 2022

Description

Motivation and Context

How Has This Been Tested?

Screenshots or GIFs (if appropriate):

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] Improvement (non-breaking change which improves existing functionality)
  • [] New feature (non-breaking change which adds new functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [] My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • [] I have updated the documentation accordingly.
  • [] I have read the CONTRIBUTING document.
  • [] I have added tests to cover my changes.
  • [] All new and existing tests passed.

@epugh
Copy link
Member

epugh commented Sep 15, 2022

image
It should say "Using OS 1" or maybe "Using OpenSearch 1"... and if you change settings then it bumps it to "Using OpenSearch 2"...

@epugh
Copy link
Member

epugh commented Sep 15, 2022

image

The explian query dialog shows some additionald debugging info, and it needs a smarter error message! since this is with OS.

@epugh
Copy link
Member

epugh commented Sep 15, 2022

@mkr we should think about using the SearchEngineFilter in more places to localize which search engine name we are showing in our messages... We have solr/es hardcoded, and now have added os... Wonder if we should use this filter instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants