targetuserspacecreator: handle properly yum.repos.d preparation for RHUI #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thank you for contributing to the Leapp project!Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
Please open ticket in case you experience technical problem with the CI. (RH internal only) Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra. |
pirat89
force-pushed
the
fix-target-userspace-yumreposd
branch
3 times, most recently
from
7c3deae
to
e5a0ea6
Compare
When creating the target userspace container, we have to handle
the /etc/yum.repos.d/ directory inside the container to provide
all required repofiles we expect to have inside the container.
Usually we just copied the original /etc/yum.repos.d from the
scratch container (and rm -rf the dir inside the container before
that).
However, we have problem especially in case of RHEL on RHUI. In such
cases the repofiles for the target RHEL systems are delivered via
the el8 rhui rpms which are installed inside the container. When
we use just an original repofiles we used to create the container,
the download of rpms fails with msgs about invalid certificates,
etc. As well, we cannot keep the old rhui repofiles present as they
could lead into duplicated data about repositories (repoids...) and
will lead to very similar issues.
To handle this correctly without breaking other solutions, the target
yum.repos.d directory has to contain:
- "original" repofiles - excluding any rhui repofiles (leapp + these
owned by RHUI [client] rpms) - and
- repofiles owned by any rpms installed inside the target userspace
container
The current solution is written in kinda hacky way, but we are going
to live with that until the planned refactoring of the actor (which
should happen relatively soon already).
pirat89
force-pushed
the
fix-target-userspace-yumreposd
branch
from
e5a0ea6
to
9365195
Compare
pirat89
changed the title
Rezney
reviewed
Oct 7, 2021
repos/system_upgrade/common/actors/targetuserspacecreator/libraries/userspacegen.py
Show resolved
Hide resolved
|
Tested, it passed both RHSM and custom repositories download. |
Rezney
approved these changes
Oct 7, 2021
pirat89
added a commit
to pirat89/leapp-repository
that referenced
this pull request
Oct 19, 2021
## Packaging - Add dependency on `dnf-command(config-manager)` (oamg#701) - Added a dependency on leapp as the new rpm provides leapp commands (oamg#701, #) - Bumped leapp-repository-dependencies to 6 (oamg#701) - Provides the leapp-upgrade capability, so users can install all packages just by the `yum install leapp-upgrade` command (oamg#701) - Support building on RHEL 8 systems: leapp-upgrade-el8toel9 (oamg#701) - The leapp-repository rpm has been renamed to leapp-upgrade-el7toel8 for RHEL 7 (oamg#701) ## Upgrade handling ### Fixes - Check all devices (not only PCI devices) for possible removed drivers (oamg#666) - Do not exclude repoids enabled via the --enablerepo option (oamg#623) - Enforce the `en_US.urf-8` locale when running leapp to prevent various issues when a different locale is used on the system (oamg#706) - Enhance the check of required free space on disk for the upgrade (oamg#734) - Fix XFS ftype=0 workaround when "non-XFS" rootfs is present (oamg#674) - Fix detection of XFS partitions without ftype (oamg#678) - Fix handling of /etc/yum.repos.d directory for RHUI (oamg#730) - Fix handling of issues when fetching leapp data files - Fix incorrect mapping of RHEL repositories (oamg#714) - Fix invalid detection of RHEL-ALT on RHEL 8 systems - Fix the detection of NFS partitions in /etc/fstab (oamg#712) - Fix the report message when multiple NICs with ethX names are present (oamg#640) - Introduce the LEAPP_NO_NETWORK_RENAMING environment variable to leave management of NICs names on user when set to '1'; fixes e.g. problems with bonding configuration (oamg#721) - Various Python3 compatibility fixes in regards to prepare for IPU 8 -> 9 (oamg#680, oamg#679, oamg#681, 688) ### Enhancements - Changed supported upgrade path for RHEL with SAP: RHEL with SAP 7.9 -> 8.2 - Add PostgresqlCheck actor for basic reporting about PostgresSQL changes (oamg#136) - Add multiple attempts to fetch data from server and increased the timeout to improve the experience on systems with unstable network connection - Add possibility to influence creation of targetuserspace container, upgrade initramfs, and target initramfs (oamg#517) - Add the scandasd actor to check if DASD is used on s390x arch (oamg#517) - Enable upgrades for SAP on AWS & Azure using RHUI (oamg#736, oamg#739) - Generate /etc/migration-results upon leapp preupgrade / upgrade execution to inform about status of the migration (oamg#719) - Improve the report message when BTRFS is detected (oamg#727) - Inhibit the upgrade if any CIFS entries found in /etc/fstab (oamg#632) - Inhibit the upgrade if any deprecated OpenSSH configuration options / directives are detected (oamg#695) - Inhibit the upgrade when multiple rescue boot entries exist on s390x (oamg#700) - Inhibit the upgrade when x32b and x64b versions of packages are installed (oamg#628) - Introduce hard preservation of leapp packages during the IPU (oamg#701) - Introduce new system of automatic mapping of RHEL repositories for the in-place upgrade based on the repomap.json file (oamg#714) - Introduce the --channel CLI option to specify the channel (e.g. eus) supposed to be used for the upgrade (oamg#728) - Report the problems with target repositories using inhibitors instead of error messages (oamg#731) - Restore the leapp environment variables on --resume execution after the reboot of the system (oamg#724) - Set `releasever` to the target version when specified in the /etc/{yum,dnf}/var/releasever file (e.g. on RHUI) (oamg#720) ## Additional changes interesting for devels - CLI: leapp CLI commands are now part of leapp-repository in the `commands` directory (oamg#662) - Drop of RepositoriesMap and RepositoryMap models as these have been replaced by new 'private' models and it was no possible to keep the original functionality connected to connected to these old models (oamg#714) - Dropped possibility to upgrade from/to HTB systems (HTB doesn't exist anymore) - Introduced many changes as preparation for the IPU 8 -> 9 - Introduced the upgrade/common leapp repository: contains fundamental parts generic for all IPUs - Introduced the upgrade/el8toel9 leapp repository: contains stuff related just for IPU 8 -> 9; depends on the upgrades/common repository - The upgrade/el7toel8 leapp repository contains only stuff related to IPU 7 -> 8 - Makefile: introduce the `fast_lint` target to run linters just on files different from master (oamg#722) - The InstalledRPM model is extended by module:stream data (oamg#667) - config library: introduce `get_target_major_version` and `get_source_major_version` functions - fetch library: the `fetch_or_read` function allows to specify the file encoding (oamg#717) - mounting library: add the remove_tree isolated action (oamg#517) - testutils library: CurrentActorMocked: implemented the get_actor_file_path method (oamg#517)
Merged
pirat89
added a commit
to pirat89/leapp-repository
that referenced
this pull request
Oct 19, 2021
## Packaging - Add dependency on `dnf-command(config-manager)` (oamg#701) - Added a dependency on leapp as the new rpm provides leapp commands (oamg#701, #) - Bumped leapp-repository-dependencies to 6 (oamg#701) - Provides the leapp-upgrade capability, so users can install all packages just by the `yum install leapp-upgrade` command (oamg#701) - Support building on RHEL 8 systems: leapp-upgrade-el8toel9 (oamg#701) - The leapp-repository rpm has been renamed to leapp-upgrade-el7toel8 for RHEL 7 (oamg#701) ## Upgrade handling ### Fixes - Check all devices (not only PCI devices) for possible removed drivers (oamg#666) - Do not exclude repoids enabled via the --enablerepo option (oamg#623) - Enforce the `en_US.urf-8` locale when running leapp to prevent various issues when a different locale is used on the system (oamg#706) - Enhance the check of required free space on disk for the upgrade (oamg#734) - Fix XFS ftype=0 workaround when "non-XFS" rootfs is present (oamg#674) - Fix detection of XFS partitions without ftype (oamg#678) - Fix handling of /etc/yum.repos.d directory for RHUI (oamg#730) - Fix handling of issues when fetching leapp data files - Fix incorrect mapping of RHEL repositories (oamg#714) - Fix invalid detection of RHEL-ALT on RHEL 8 systems - Fix the detection of NFS partitions in /etc/fstab (oamg#712) - Fix the report message when multiple NICs with ethX names are present (oamg#640) - Introduce the LEAPP_NO_NETWORK_RENAMING environment variable to leave management of NICs names on user when set to '1'; fixes e.g. problems with bonding configuration (oamg#721) - Various Python3 compatibility fixes in regards to prepare for IPU 8 -> 9 (oamg#680, oamg#679, oamg#681, oamg#688) ### Enhancements - Changed supported upgrade path for RHEL with SAP: RHEL with SAP 7.9 -> 8.2 - Add PostgresqlCheck actor for basic reporting about PostgresSQL changes (oamg#136) - Add multiple attempts to fetch data from server and increased the timeout to improve the experience on systems with unstable network connection - Add possibility to influence creation of targetuserspace container, upgrade initramfs, and target initramfs (oamg#517) - Add the scandasd actor to check if DASD is used on s390x arch (oamg#517) - Enable upgrades for SAP on AWS & Azure using RHUI (oamg#736, oamg#739) - Generate /etc/migration-results upon leapp preupgrade / upgrade execution to inform about status of the migration (oamg#719) - Improve the report message when BTRFS is detected (oamg#727) - Inhibit the upgrade if any CIFS entries found in /etc/fstab (oamg#632) - Inhibit the upgrade if any deprecated OpenSSH configuration options / directives are detected (oamg#695) - Inhibit the upgrade when multiple rescue boot entries exist on s390x (oamg#700) - Inhibit the upgrade when x32b and x64b versions of packages are installed (oamg#628) - Introduce hard preservation of leapp packages during the IPU (oamg#701) - Introduce new system of automatic mapping of RHEL repositories for the in-place upgrade based on the repomap.json file (oamg#714) - Introduce the --channel CLI option to specify the channel (e.g. eus) supposed to be used for the upgrade (oamg#728) - Report the problems with target repositories using inhibitors instead of error messages (oamg#731) - Restore the leapp environment variables on --resume execution after the reboot of the system (oamg#724) - Set `releasever` to the target version when specified in the /etc/{yum,dnf}/var/releasever file (e.g. on RHUI) (oamg#720) ## Additional changes interesting for devels - CLI: leapp CLI commands are now part of leapp-repository in the `commands` directory (oamg#662) - Drop of RepositoriesMap and RepositoryMap models as these have been replaced by new 'private' models and it was no possible to keep the original functionality connected to connected to these old models (oamg#714) - Dropped possibility to upgrade from/to HTB systems (HTB doesn't exist anymore) - Introduced many changes as preparation for the IPU 8 -> 9 - Introduced the upgrade/common leapp repository: contains fundamental parts generic for all IPUs - Introduced the upgrade/el8toel9 leapp repository: contains stuff related just for IPU 8 -> 9; depends on the upgrades/common repository - The upgrade/el7toel8 leapp repository contains only stuff related to IPU 7 -> 8 - Makefile: introduce the `fast_lint` target to run linters just on files different from master (oamg#722) - The InstalledRPM model is extended by module:stream data (oamg#667) - config library: introduce `get_target_major_version` and `get_source_major_version` functions - fetch library: the `fetch_or_read` function allows to specify the file encoding (oamg#717) - mounting library: add the remove_tree isolated action (oamg#517) - testutils library: CurrentActorMocked: implemented the get_actor_file_path method (oamg#517)
pirat89
added a commit
to pirat89/leapp-repository
that referenced
this pull request
Oct 19, 2021
## Packaging - Add dependency on `dnf-command(config-manager)` (oamg#701) - Added a dependency on leapp as the new rpm provides leapp commands (oamg#701, #) - Bumped leapp-repository-dependencies to 6 (oamg#701) - Provides the leapp-upgrade capability, so users can install all packages just by the `yum install leapp-upgrade` command (oamg#701) - Support building on RHEL 8 systems: leapp-upgrade-el8toel9 (oamg#701) - The leapp-repository rpm has been renamed to leapp-upgrade-el7toel8 for RHEL 7 (oamg#701) ## Upgrade handling ### Fixes - Check all devices (not only PCI devices) for possible removed drivers (oamg#666) - Do not exclude repoids enabled via the --enablerepo option (oamg#623) - Enforce the `en_US.urf-8` locale when running leapp to prevent various issues when a different locale is used on the system (oamg#706) - Enhance the check of required free space on disk for the upgrade (oamg#734) - Fix XFS ftype=0 workaround when "non-XFS" rootfs is present (oamg#674) - Fix detection of XFS partitions without ftype (oamg#678) - Fix handling of /etc/yum.repos.d directory for RHUI (oamg#730) - Fix handling of issues when fetching leapp data files - Fix incorrect mapping of RHEL repositories (oamg#714) - Fix invalid detection of RHEL-ALT on RHEL 8 systems - Fix the detection of NFS partitions in /etc/fstab (oamg#712) - Fix the report message when multiple NICs with ethX names are present (oamg#640) - Introduce the LEAPP_NO_NETWORK_RENAMING environment variable to leave management of NICs names on user when set to '1'; fixes e.g. problems with bonding configuration (oamg#721) - Various Python3 compatibility fixes in regards to prepare for IPU 8 -> 9 (oamg#680, oamg#679, oamg#681, oamg#688) ### Enhancements - Changed supported upgrade path for RHEL with SAP: RHEL with SAP 7.9 -> 8.2 - Add PostgresqlCheck actor for basic reporting about PostgresSQL changes (oamg#136) - Add multiple attempts to fetch data from server and increased the timeout to improve the experience on systems with unstable network connection - Add possibility to influence creation of targetuserspace container, upgrade initramfs, and target initramfs (oamg#517) - Add the scandasd actor to check if DASD is used on s390x arch (oamg#517) - Enable upgrades for SAP on AWS & Azure using RHUI (oamg#736, oamg#739) - Generate /etc/migration-results upon leapp preupgrade / upgrade execution to inform about status of the migration (oamg#719) - Improve the report message when BTRFS is detected (oamg#727) - Inhibit the upgrade if any CIFS entries found in /etc/fstab (oamg#632) - Inhibit the upgrade if any deprecated OpenSSH configuration options / directives are detected (oamg#695) - Inhibit the upgrade when multiple rescue boot entries exist on s390x (oamg#700) - Inhibit the upgrade when x32b and x64b versions of packages are installed (oamg#628) - Introduce hard preservation of leapp packages during the IPU (oamg#701) - Introduce new system of automatic mapping of RHEL repositories for the in-place upgrade based on the repomap.json file (oamg#714) - Introduce the --channel CLI option to specify the channel (e.g. eus) supposed to be used for the upgrade (oamg#728) - Report the problems with target repositories using inhibitors instead of error messages (oamg#731) - Restore the leapp environment variables on --resume execution after the reboot of the system (oamg#724) - Set `releasever` to the target version when specified in the /etc/{yum,dnf}/var/releasever file (e.g. on RHUI) (oamg#720) ## Additional changes interesting for devels - CLI: leapp CLI commands are now part of leapp-repository in the `commands` directory (oamg#662) - Drop of RepositoriesMap and RepositoryMap models as these have been replaced by new 'private' models and it was no possible to keep the original functionality connected to connected to these old models (oamg#714) - Dropped possibility to upgrade from/to HTB systems (HTB doesn't exist anymore) - Introduced the LEAPP_DEVEL_USE_PERSISTENT_PACKAGE_CACHE envar for development and testing purposes to speed up the process, but use of the envar could end with some issues when the cached data is not fresh (oamg#725) - Introduced many changes as preparation for the IPU 8 -> 9 - Introduced the upgrade/common leapp repository: contains fundamental parts generic for all IPUs - Introduced the upgrade/el8toel9 leapp repository: contains stuff related just for IPU 8 -> 9; depends on the upgrades/common repository - The upgrade/el7toel8 leapp repository contains only stuff related to IPU 7 -> 8 - Makefile: introduce the `fast_lint` target to run linters just on files different from master (oamg#722) - The InstalledRPM model is extended by module:stream data (oamg#667) - config library: introduce `get_target_major_version` and `get_source_major_version` functions - fetch library: the `fetch_or_read` function allows to specify the file encoding (oamg#717) - mounting library: add the remove_tree isolated action (oamg#517) - testutils library: CurrentActorMocked: implemented the get_actor_file_path method (oamg#517)
pirat89
added a commit
to pirat89/leapp-repository
that referenced
this pull request
Oct 19, 2021
## Packaging - Add dependency on `dnf-command(config-manager)` (oamg#701) - Added a dependency on leapp as the new rpm provides leapp commands (oamg#701, #) - Bumped leapp-repository-dependencies to 6 (oamg#701) - Provides the leapp-upgrade capability, so users can install all packages just by the `yum install leapp-upgrade` command (oamg#701) - Support building on RHEL 8 systems: leapp-upgrade-el8toel9 (oamg#701) - The leapp-repository rpm has been renamed to leapp-upgrade-el7toel8 for RHEL 7 (oamg#701) ## Upgrade handling ### Fixes - Check all devices (not only PCI devices) for possible removed drivers (oamg#666) - Do not exclude repoids enabled via the --enablerepo option (oamg#623) - Enforce the `en_US.utf-8` locale when running leapp to prevent various issues when a different locale is used on the system (oamg#706) - Enhance the check of required free space on disk for the upgrade (oamg#734) - Fix XFS ftype=0 workaround when "non-XFS" rootfs is present (oamg#674) - Fix detection of XFS partitions without ftype (oamg#678) - Fix handling of /etc/yum.repos.d directory for RHUI (oamg#730) - Fix handling of issues when fetching leapp data files - Fix incorrect mapping of RHEL repositories (oamg#714) - Fix invalid detection of RHEL-ALT on RHEL 8 systems - Fix the detection of NFS partitions in /etc/fstab (oamg#712) - Fix the report message when multiple NICs with ethX names are present (oamg#640) - Introduce the LEAPP_NO_NETWORK_RENAMING environment variable to leave management of NICs names on user when set to '1'; fixes e.g. problems with bonding configuration (oamg#721) - Various Python3 compatibility fixes in regards to prepare for IPU 8 -> 9 (oamg#680, oamg#679, oamg#681, oamg#688) ### Enhancements - Changed supported upgrade path for RHEL with SAP: RHEL with SAP 7.9 -> 8.2 - Add PostgresqlCheck actor for basic reporting about PostgresSQL changes (oamg#136) - Add multiple attempts to fetch data from server and increased the timeout to improve the experience on systems with unstable network connection - Add possibility to influence creation of targetuserspace container, upgrade initramfs, and target initramfs (oamg#517) - Add the scandasd actor to check if DASD is used on s390x arch (oamg#517) - Enable upgrades for SAP on AWS & Azure using RHUI (oamg#736, oamg#739) - Generate /etc/migration-results upon leapp preupgrade / upgrade execution to inform about status of the migration (oamg#719) - Improve the report message when BTRFS is detected (oamg#727) - Inhibit the upgrade if any CIFS entries found in /etc/fstab (oamg#632) - Inhibit the upgrade if any deprecated OpenSSH configuration options / directives are detected (oamg#695) - Inhibit the upgrade when multiple rescue boot entries exist on s390x (oamg#700) - Inhibit the upgrade when x32b and x64b versions of packages are installed (oamg#628) - Introduce hard preservation of leapp packages during the IPU (oamg#701) - Introduce new system of automatic mapping of RHEL repositories for the in-place upgrade based on the repomap.json file (oamg#714) - Introduce the --channel CLI option to specify the channel (e.g. eus) supposed to be used for the upgrade (oamg#728) - Report the problems with target repositories using inhibitors instead of error messages (oamg#731) - Restore the leapp environment variables on --resume execution after the reboot of the system (oamg#724) - Update (or create) the /etc/{yum,dnf}/var/releasever file if exists or RHUI is detected (oamg#720) ## Additional changes interesting for devels - CLI: leapp CLI commands are now part of leapp-repository in the `commands` directory (oamg#662) - Drop of RepositoriesMap and RepositoryMap models as these have been replaced by new 'private' models and it was no possible to keep the original functionality connected to connected to these old models (oamg#714) - Dropped possibility to upgrade from/to HTB systems (HTB doesn't exist anymore) - Introduced the LEAPP_DEVEL_USE_PERSISTENT_PACKAGE_CACHE envar for development and testing purposes to speed up the process, but use of the envar could end with some issues when the cached data is not fresh (oamg#725) - Introduced many changes as preparation for the IPU 8 -> 9 - Introduced the upgrade/common leapp repository: contains fundamental parts generic for all IPUs - Introduced the upgrade/el8toel9 leapp repository: contains stuff related just for IPU 8 -> 9; depends on the upgrades/common repository - The upgrade/el7toel8 leapp repository contains only stuff related to IPU 7 -> 8 - Makefile: introduce the `fast_lint` target to run linters just on files different from master (oamg#722) - The InstalledRPM model is extended by module:stream data (oamg#667) - config library: introduce `get_target_major_version` and `get_source_major_version` functions - fetch library: the `fetch_or_read` function allows to specify the file encoding (oamg#717) - mounting library: add the remove_tree isolated action (oamg#517) - testutils library: CurrentActorMocked: implemented the get_actor_file_path method (oamg#517)
pirat89
added a commit
that referenced
this pull request
Oct 19, 2021
## Packaging - Add dependency on `dnf-command(config-manager)` (#701) - Added a dependency on leapp as the new rpm provides leapp commands (#701, #) - Bumped leapp-repository-dependencies to 6 (#701) - Provides the leapp-upgrade capability, so users can install all packages just by the `yum install leapp-upgrade` command (#701) - Support building on RHEL 8 systems: leapp-upgrade-el8toel9 (#701) - The leapp-repository rpm has been renamed to leapp-upgrade-el7toel8 for RHEL 7 (#701) ## Upgrade handling ### Fixes - Check all devices (not only PCI devices) for possible removed drivers (#666) - Do not exclude repoids enabled via the --enablerepo option (#623) - Enforce the `en_US.utf-8` locale when running leapp to prevent various issues when a different locale is used on the system (#706) - Enhance the check of required free space on disk for the upgrade (#734) - Fix XFS ftype=0 workaround when "non-XFS" rootfs is present (#674) - Fix detection of XFS partitions without ftype (#678) - Fix handling of /etc/yum.repos.d directory for RHUI (#730) - Fix handling of issues when fetching leapp data files - Fix incorrect mapping of RHEL repositories (#714) - Fix invalid detection of RHEL-ALT on RHEL 8 systems - Fix the detection of NFS partitions in /etc/fstab (#712) - Fix the report message when multiple NICs with ethX names are present (#640) - Introduce the LEAPP_NO_NETWORK_RENAMING environment variable to leave management of NICs names on user when set to '1'; fixes e.g. problems with bonding configuration (#721) - Various Python3 compatibility fixes in regards to prepare for IPU 8 -> 9 (#680, #679, #681, #688) ### Enhancements - Changed supported upgrade path for RHEL with SAP: RHEL with SAP 7.9 -> 8.2 - Add PostgresqlCheck actor for basic reporting about PostgresSQL changes (#136) - Add multiple attempts to fetch data from server and increased the timeout to improve the experience on systems with unstable network connection - Add possibility to influence creation of targetuserspace container, upgrade initramfs, and target initramfs (#517) - Add the scandasd actor to check if DASD is used on s390x arch (#517) - Enable upgrades for SAP on AWS & Azure using RHUI (#736, #739) - Generate /etc/migration-results upon leapp preupgrade / upgrade execution to inform about status of the migration (#719) - Improve the report message when BTRFS is detected (#727) - Inhibit the upgrade if any CIFS entries found in /etc/fstab (#632) - Inhibit the upgrade if any deprecated OpenSSH configuration options / directives are detected (#695) - Inhibit the upgrade when multiple rescue boot entries exist on s390x (#700) - Inhibit the upgrade when x32b and x64b versions of packages are installed (#628) - Introduce hard preservation of leapp packages during the IPU (#701) - Introduce new system of automatic mapping of RHEL repositories for the in-place upgrade based on the repomap.json file (#714) - Introduce the --channel CLI option to specify the channel (e.g. eus) supposed to be used for the upgrade (#728) - Report the problems with target repositories using inhibitors instead of error messages (#731) - Restore the leapp environment variables on --resume execution after the reboot of the system (#724) - Update (or create) the /etc/{yum,dnf}/var/releasever file if exists or RHUI is detected (#720) ## Additional changes interesting for devels - CLI: leapp CLI commands are now part of leapp-repository in the `commands` directory (#662) - Drop of RepositoriesMap and RepositoryMap models as these have been replaced by new 'private' models and it was no possible to keep the original functionality connected to connected to these old models (#714) - Dropped possibility to upgrade from/to HTB systems (HTB doesn't exist anymore) - Introduced the LEAPP_DEVEL_USE_PERSISTENT_PACKAGE_CACHE envar for development and testing purposes to speed up the process, but use of the envar could end with some issues when the cached data is not fresh (#725) - Introduced many changes as preparation for the IPU 8 -> 9 - Introduced the upgrade/common leapp repository: contains fundamental parts generic for all IPUs - Introduced the upgrade/el8toel9 leapp repository: contains stuff related just for IPU 8 -> 9; depends on the upgrades/common repository - The upgrade/el7toel8 leapp repository contains only stuff related to IPU 7 -> 8 - Makefile: introduce the `fast_lint` target to run linters just on files different from master (#722) - The InstalledRPM model is extended by module:stream data (#667) - config library: introduce `get_target_major_version` and `get_source_major_version` functions - fetch library: the `fetch_or_read` function allows to specify the file encoding (#717) - mounting library: add the remove_tree isolated action (#517) - testutils library: CurrentActorMocked: implemented the get_actor_file_path method (#517)
MichalHe
pushed a commit
to MichalHe/leapp-repository
that referenced
this pull request
Jun 21, 2022
As tmt-plans repository now contains morf tests for convert2rhel this is needed to filter out tests that make no sense for leapp.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating the target userspace container, we have to handle
the /etc/yum.repos.d/ directory inside the container to provide
all required repofiles we expect to have inside the container.
Usually we just copied the original /etc/yum.repos.d from the
scratch container (and rm -rf the dir inside the container before
that).
However, we have problem especially in case of RHEL on RHUI. In such
cases the repofiles for the target RHEL systems are delivered via
the el8 rhui rpms which are installed inside the container. When
we use just an original repofiles we used to create the container,
the download of rpms fails with msgs about invalid certificates,
etc. As well, we cannot keep the old rhui repofiles present as they
could lead into duplicated data about repositories (repoids...) and
will lead to very similar issues.
To handle this correctly without breaking other solutions, the target
yum.repos.d directory has to contain:
owned by RHUI [client] rpms) - and
container
The current solution is written in kinda hacky way, but we are going
to live with that until the planned refactoring of the actor (which
should happen relatively soon already).