Provide upgrade inhibitor for ipa-server #765

flo-renaud · 2021-11-26T09:55:27Z

IdM (ipa-server) does not support in-place upgrade from RHEL 8 to 9.
Instead IdM servers must be upgraded by creating a new RHEL 9 machine
and installing a replica.

The new IpaScanner actor scans for the system for IdM packages and
client/server instances. The new CheckIPAServer prohibits upgrades when
an IdM server is installed and warns the user when ipa-server package is
present.

Code largely taken from the el7toel8 existing inhibitor (credits to
cheimes@redhat.com)
Signed-off-by: Florence Blanc-Renaud flo@redhat.com

github-actions · 2021-11-26T09:55:40Z

Thank you for contributing to the Leapp project!

Please note that every PR needs to comply with the Leapp Guidelines and must pass all tests in order to be mergable.
If you want to re-run tests or request review, you can use following commands as a comment:

leapp-ci build to run copr build and e2e tests in OAMG CI
review please to notify leapp developers of review request

Please open ticket in case you experience technical problem with the CI. (RH internal only)

Note: In case there are problems with tests not being triggered automatically on new PR/commit or pending for a long time, please consider rerunning the CI by commenting leapp-ci build (might require several comments). If the problem persists, contact leapp-infra.

flo-renaud · 2021-11-26T12:55:26Z

review please

leapp-bot · 2021-11-27T18:23:35Z

This PR has been linked in issue tracker (#OAMG-6120).

repos/system_upgrade/el8toel9/actors/checkipaserver/actor.py

repos/system_upgrade/el8toel9/actors/checkipaserver/libraries/checkipaserver.py

pirat89

the IpaScanner8to9 looks same as ipascanner for 7 to 8 - is it correct? In such a case, do not create new scanner actor and model and just move the stuff from system_upgrades/el7toel8 repository to the system_upgrades/common repository.

I am sorry I haven't done complete review now regarding limited time, but at least something for the start

flo-renaud · 2021-12-06T15:27:12Z

@pirat89 thanks for your review comments. I moved the actors to system_upgrades/common as recommended.

flo-renaud · 2021-12-13T07:54:18Z

review please

leapp-bot · 2021-12-16T08:04:58Z

Review requested from oamg/developers team.

MichalHe · 2021-12-22T18:50:27Z

leapp-ci build

MichalHe

Hello, thank you for contributing.

I've went through the changes introduced in this PR. The code looks OK, and except the raised concerns about providing a link to IdM 7->8 migration guide even if upgrading from rhel8 to rhel9, I see no problems. I've also manually tested this patch and the upgrade gets inhibited on both rhel7 and rhel8.

The source branch is a bit behind the master, could you please rebase it? The failed CI tests are due to us recently introducing import order enforcing and the linting errors causing the CI to fail are already fixed in the master.

MichalHe · 2021-12-22T22:49:50Z

repos/system_upgrade/common/actors/checkipaserver/libraries/checkipaserver.py

        ),
        reporting.Remediation(
-            hint="Please follow the IdM RHEL 7 to 8 migration guide lines."
+            hint="Follow the IdM RHEL migration guide lines."
        ),
        reporting.ExternalLink(
            url=MIGRATION_GUIDE, title="Migrating IdM from RHEL 7 to 8",


This external link might be misleading when upgrading from RHEL8 to RHEL9 and inhibition conditions are met.
Is there a IdM 8 to 9 migration guide?

If yes, the global variable MIGRATION_GUIDE could be changed to be a dictionary mapping source OS major version to the migration guides:

MIGRATION_GUIDES = { '7': 'link-to-7to8-guide', '8': 'link-to-8to9-guide' }

The source OS major version can be determined using the get_source_major_version function implemented in the leapp.libraries.common.config.version module.

Then the report creation could look for example in the following fashion:

Suggested change

url=MIGRATION_GUIDE, title="Migrating IdM from RHEL 7 to 8",

url=MIGRATION_GUIDES[get_source_major_version()], title="IdM migration guide",

Unfortunately we don't have any 8->9 migration guide yet.

After a discussion with @Rezney, we've arrived at conclusion that we will track the missing documentation link internally and modify the code accordingly once the guide becomes available. As we would like to avoid providing a link to incorrect migration guide when upgrading from 8 to 9, could you please change the code according to the suggestions above and use TBA for the missing upgrade link?

flo-renaud · 2021-12-23T12:01:15Z

Thanks for the review. I rebased my PR to the master.

flo-renaud · 2021-12-23T15:00:27Z

leapp-ci build

flo-renaud · 2022-01-06T07:10:18Z

review please

MichalHe · 2022-01-06T11:31:19Z

Hi 👋

I've left a comment about the missing migration guide link. Code-wise the patch looks OK, and once the comment is resolved, there should be nothing preventing merging this patch into the master.

Rezney · 2022-01-06T16:00:58Z

@flo-renaud Hi, actually, feel free to make a shortener URL and add it instead of "TBA".

It can be something like this (used in different PR): https://red.ht/upgrading-RHEL-8-to-RHEL-9-network-scripts, we will take care of feeding the correct underlying URL when it is available.
Thanks...

IdM (ipa-server) does not support in-place upgrade from RHEL 8 to 9. Instead IdM servers must be upgraded by creating a new RHEL 9 machine and installing a replica. Since there is already an inhibitor for el7to8 migration, this commit - moves the code from system_upgrades/el7toel8 to system_upgrades/common - fixes lint issues - removes specific references to "7 to 8 migration" to make the messages more generic Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>

flo-renaud · 2022-01-10T12:51:22Z

leap-ci build

flo-renaud · 2022-01-10T13:32:23Z

leapp-ci build

fernflower · 2022-01-10T17:29:04Z

leapp-ci build

flo-renaud · 2022-01-11T15:37:30Z

@Rezney thanks for the suggestion, I followed your advice in the latest update.
The CI is failing in continuous-integration/oamg-ci/e2e but it doesn't look related to my changes. Is there anything I need to do on my side?

fernflower · 2022-01-11T18:29:23Z

@flo-renaud No, e2e test failure is not your fault, we are having some infra issues unfortunately but we are on it :)

fernflower

lgtm, once the infra issue is resolved I will launch regression tests.

flo-renaud · 2022-01-17T09:16:11Z

@fernflower the tests are now green

The requested changes have been implemented (code was migrated to common repository)

MichalHe

LGTM. Tested on rhel8 with ipa-server installled & configured - the upgrade gets correctly inhibited.

MichalHe · 2022-01-17T11:29:13Z

The used link to the documentation is tracked internally in order to check its validity before the release. As the current link is a placeholder allowing for the code to be merged, please let us know when you release the guide and share the link, as it is important for us that all documentation links are pointing to existing docs.

flo-renaud · 2022-01-17T16:33:35Z

The used link to the documentation is tracked internally in order to check its validity before the release. As the current link is a placeholder allowing for the code to be merged, please let us know when you release the guide and share the link, as it is important for us that all documentation links are pointing to existing docs.

@MichalHe The documentation team will track a jira issue in order to update your team with the new url as soon as it's available. Thanks for the merge!

## Packaging - Requires leapp-framework >= 2.2 - Bump leapp-framework-dependencies to 5 ## Upgrade handling ### Fixes - Fallback to /etc/leapp/repos.d if missing config option instead of using cwd (oamg#849) - Filter out unrelated PES data for the particular IPU path (oamg#789) - Fix bug with existing symlink when migrating YUM configuration files (oamg#811) - Fix creating invalid answerfile in "authselectcheck" actor (oamg#748) - Fix generating of instructions/data for the leapp DNF plugin during the IPU (oamg#754) - Fix generating the target initramfs when additional files and dracut modules are requested to be added (oamg#838) - Fix getting device attribute through udev on Python 3 (oamg#758) - Fix parsing of sysctl output (oamg#793) - Fix processing of merge events from PES data (oamg#768, oamg#825) - Fix random crashes when printing DNF output (oamg#745) - Fix scanning "/etc/default/grub" with empty line (oamg#845) - Fix scanning information about mounted devices (oamg#711) - Fix severities in the "targetuserspacecreator" actor (oamg#751) - Fix the "rerun" command after adding the "--channel" option (oamg#750) - Fix the execution order for the dnf dry run actor (oamg#801) - Skip checking the flavor and target_version upon leapp --resume (oamg#781) - Use more accurate tense in the SELinux messaging (oamg#614) ### Enhancements - Introduce IPU for RHEL 8 to RHEL 9 \o/ - New upgrade paths for RHEL with SAP HANA (oamg#834) - Changed upgrade paths: -- RHEL 7.9 -> [8.4, 8.6] (default: 8.6) -- RHEL 8.6 -> 9.0 -- RHEL with SAP 7.9 -> [8.2, 8.6] (default: 8.2) -- RHEL with SAP 8.6 -> 9.0 - Add 8.6, 9.0 Beta & GA product certificates (oamg#776, oamg#794) - Add detection of enabled YUM & DNF plugins (oamg#703) - Bind the /run/lock dir into the container in the upgrade initramfs env (oamg#831) - Enable RHEL 8 to RHEL 9 upgrades on RHUI for AWS (oamg#828) - Enhance handling selinux related stuff for 8 to 9 upgrade (oamg#749) - Generalize checking of device drivers (oamg#835) - Improve the performance of the leapp execution for "pre first reboot" phases (oamg#741) - Introduce DNFWorkarounds to register scripts to be executed before DNF run (oamg#841) - Introduce DNF modularity support (oamg#672, oamg#799) - Introduce the --report-schema option to control the version of the generated report format (oamg#696) - Introduce the --target option to specify the version of the target system (oamg#780) - Provide the LEAPP_IPU_IN_PROGRESS envar during the IPU (oamg#830) - [IPU 7 -> 8]: Add CUPS actors - cupsscanner, cupscheck, cupsmigrate (oamg#181) - [IPU 7 -> 8]: Convert restrictions with IPv6 mask in "migratentp" actor (oamg#756) - [IPU 7 -> 8]: Handle upgrading Satellite instances (oamg#733) - [IPU 7 -> 8]: Warn about docker deprecation when installed - [IPU 7 -> 8]: Zipl: Inhibit if boot entries share the same kernel image (oamg#816) - [IPU 7 -> 8]: bind configuration check (oamg#521) - [IPU 8 -> 9]: Add actor that ensures ifcfg files work in el9 (oamg#839) - [IPU 8 -> 9]: Add actor that scans for deprecated network settings (oamg#842) - [IPU 8 -> 9]: Add inhibitor FirewalldCheckServiceTftpClient (oamg#792) - [IPU 8 -> 9]: Add inihibtor FirewalldCheckAllowZoneDrifting (oamg#777) - [IPU 8 -> 9]: Add kpatch actor to handle live kernel patching during IPU (oamg#837) - [IPU 8 -> 9]: Add mariadbcheck actor to link upgrade documentation (oamg#836) - [IPU 8 -> 9]: Add postgresqlcheck actor to link upgrade documentation (oamg#802) - [IPU 8 -> 9]: Add scan & checks for VDO devices (oamg#821) - [IPU 8 -> 9]: Apply a new way of disabling SELinux (oamg#769) - [IPU 8 -> 9]: Check SSSD configuration for changes in RHEL9 and report them (oamg#732) - [IPU 8 -> 9]: Check the existence of the custom network-scripts (oamg#729) - [IPU 8 -> 9]: Provide upgrade inhibitor for ipa-server (oamg#765) ## Additional changes interesting for devels - Move target release and flavor specification to a separate lib (oamg#753) - Refactor "transactionworkarounds" actor and fix tests (oamg#759) - Several actors moved to the system_upgrade/common repository (oamg#800, oamg#803, oamg#805, oamg#833)

## Packaging - Requires leapp-framework >= 2.2 - Bump leapp-framework-dependencies to 5 ## Upgrade handling ### Fixes - Fallback to /etc/leapp/repos.d if missing config option instead of using cwd (oamg#849) - Filter out unrelated PES data for the particular IPU path (oamg#789) - Fix bug with existing symlink when migrating YUM configuration files (oamg#811) - Fix creating invalid answerfile in "authselectcheck" actor (oamg#748) - Fix generating of instructions/data for the leapp DNF plugin during the IPU (oamg#754) - Fix generating the target initramfs when additional files and dracut modules are requested to be added (oamg#838) - Fix getting device attribute through udev on Python 3 (oamg#758) - Fix parsing of sysctl output (oamg#793) - Fix processing of merge events from PES data (oamg#768, oamg#825) - Fix random crashes when printing DNF output (oamg#745) - Fix scanning "/etc/default/grub" with empty line (oamg#845) - Fix scanning information about mounted devices (oamg#711) - Fix severities in the "targetuserspacecreator" actor (oamg#751) - Fix the "rerun" command after adding the "--channel" option (oamg#750) - Fix the execution order for the dnf dry run actor (oamg#801) - Skip checking the flavor and target_version upon leapp --resume (oamg#781) - Use more accurate tense in the SELinux messaging (oamg#614) ### Enhancements - Introduce IPU for RHEL 8 to RHEL 9 \o/ - New upgrade paths for RHEL with SAP HANA (oamg#834) - Changed upgrade paths: -- RHEL 7.9 -> [8.4, 8.6] (default: 8.6) -- RHEL 8.6 -> 9.0 -- RHEL with SAP 7.9 -> [8.2, 8.6] (default: 8.2) -- RHEL with SAP 8.6 -> 9.0 - Add 8.6, 9.0 Beta & GA product certificates (oamg#776, oamg#794) - Add detection of enabled YUM & DNF plugins (oamg#703) - Bind the /run/lock dir into the container in the upgrade initramfs env (oamg#831) - Enable RHEL 8 to RHEL 9 upgrades on RHUI for AWS (oamg#828) - Enhance handling selinux related stuff for 8 to 9 upgrade (oamg#749) - Generalize checking of device drivers (oamg#835) - Improve the performance of the leapp execution for "pre first reboot" phases (oamg#741) - Introduce DNFWorkarounds to register scripts to be executed before DNF run (oamg#841) - Introduce DNF modularity support (oamg#672, oamg#799) - Introduce the --report-schema option to control the version of the generated report format (oamg#696) - Introduce the --target option to specify the version of the target system (oamg#780) - Provide the LEAPP_IPU_IN_PROGRESS envar during the IPU (oamg#830) - [IPU 7 -> 8]: Add CUPS actors - cupsscanner, cupscheck, cupsmigrate (oamg#181) - [IPU 7 -> 8]: Convert restrictions with IPv6 mask in "migratentp" actor (oamg#756) - [IPU 7 -> 8]: Handle upgrading Satellite instances (oamg#733) - [IPU 7 -> 8]: Warn about docker deprecation when installed - [IPU 7 -> 8]: Zipl: Inhibit if boot entries share the same kernel image (oamg#816) - [IPU 7 -> 8]: bind configuration check (oamg#521) - [IPU 8 -> 9]: Add actor that ensures ifcfg files work in el9 (oamg#839) - [IPU 8 -> 9]: Add actor that scans for deprecated network settings (oamg#842) - [IPU 8 -> 9]: Add inhibitor FirewalldCheckServiceTftpClient (oamg#792) - [IPU 8 -> 9]: Add inihibtor FirewalldCheckAllowZoneDrifting (oamg#777) - [IPU 8 -> 9]: Add kpatch actor to handle live kernel patching during IPU (oamg#837) - [IPU 8 -> 9]: Add mariadbcheck actor to link upgrade documentation (oamg#836) - [IPU 8 -> 9]: Add postgresqlcheck actor to link upgrade documentation (oamg#802) - [IPU 8 -> 9]: Add scan & checks for VDO devices (oamg#821) - [IPU 8 -> 9]: Apply a new way of disabling SELinux (oamg#769) - [IPU 8 -> 9]: Check SSSD configuration for changes in RHEL9 and report them (oamg#732) - [IPU 8 -> 9]: Check the existence of the custom network-scripts (oamg#729) - [IPU 8 -> 9]: Provide upgrade inhibitor for ipa-server (oamg#765) ## Additional changes interesting for devels - Move target release and flavor specification to a separate lib (oamg#753) - Refactor "transactionworkarounds" actor and fix tests (oamg#759) - Several actors moved to the system_upgrade/common repository (oamg#800, oamg#803, oamg#805, oamg#833) Signed-off-by: Michal Reznik <mreznik@redhat.com>

## Packaging - Requires leapp-framework >= 2.2 - Bump leapp-framework-dependencies to 5 ## Upgrade handling ### Fixes - Fallback to /etc/leapp/repos.d if missing config option instead of using cwd (#849) - Filter out unrelated PES data for the particular IPU path (#789) - Fix bug with existing symlink when migrating YUM configuration files (#811) - Fix creating invalid answerfile in "authselectcheck" actor (#748) - Fix generating of instructions/data for the leapp DNF plugin during the IPU (#754) - Fix generating the target initramfs when additional files and dracut modules are requested to be added (#838) - Fix getting device attribute through udev on Python 3 (#758) - Fix parsing of sysctl output (#793) - Fix processing of merge events from PES data (#768, #825) - Fix random crashes when printing DNF output (#745) - Fix scanning "/etc/default/grub" with empty line (#845) - Fix scanning information about mounted devices (#711) - Fix severities in the "targetuserspacecreator" actor (#751) - Fix the "rerun" command after adding the "--channel" option (#750) - Fix the execution order for the dnf dry run actor (#801) - Skip checking the flavor and target_version upon leapp --resume (#781) - Use more accurate tense in the SELinux messaging (#614) ### Enhancements - Introduce IPU for RHEL 8 to RHEL 9 \o/ - New upgrade paths for RHEL with SAP HANA (#834) - Changed upgrade paths: -- RHEL 7.9 -> [8.4, 8.6] (default: 8.6) -- RHEL 8.6 -> 9.0 -- RHEL with SAP 7.9 -> [8.2, 8.6] (default: 8.2) -- RHEL with SAP 8.6 -> 9.0 - Add 8.6, 9.0 Beta & GA product certificates (#776, #794) - Add detection of enabled YUM & DNF plugins (#703) - Bind the /run/lock dir into the container in the upgrade initramfs env (#831) - Enable RHEL 8 to RHEL 9 upgrades on RHUI for AWS (#828) - Enhance handling selinux related stuff for 8 to 9 upgrade (#749) - Generalize checking of device drivers (#835) - Improve the performance of the leapp execution for "pre first reboot" phases (#741) - Introduce DNFWorkarounds to register scripts to be executed before DNF run (#841) - Introduce DNF modularity support (#672, #799) - Introduce the --report-schema option to control the version of the generated report format (#696) - Introduce the --target option to specify the version of the target system (#780) - Provide the LEAPP_IPU_IN_PROGRESS envar during the IPU (#830) - [IPU 7 -> 8]: Add CUPS actors - cupsscanner, cupscheck, cupsmigrate (#181) - [IPU 7 -> 8]: Convert restrictions with IPv6 mask in "migratentp" actor (#756) - [IPU 7 -> 8]: Handle upgrading Satellite instances (#733) - [IPU 7 -> 8]: Warn about docker deprecation when installed - [IPU 7 -> 8]: Zipl: Inhibit if boot entries share the same kernel image (#816) - [IPU 7 -> 8]: bind configuration check (#521) - [IPU 8 -> 9]: Add actor that ensures ifcfg files work in el9 (#839) - [IPU 8 -> 9]: Add actor that scans for deprecated network settings (#842) - [IPU 8 -> 9]: Add inhibitor FirewalldCheckServiceTftpClient (#792) - [IPU 8 -> 9]: Add inihibtor FirewalldCheckAllowZoneDrifting (#777) - [IPU 8 -> 9]: Add kpatch actor to handle live kernel patching during IPU (#837) - [IPU 8 -> 9]: Add mariadbcheck actor to link upgrade documentation (#836) - [IPU 8 -> 9]: Add postgresqlcheck actor to link upgrade documentation (#802) - [IPU 8 -> 9]: Add scan & checks for VDO devices (#821) - [IPU 8 -> 9]: Apply a new way of disabling SELinux (#769) - [IPU 8 -> 9]: Check SSSD configuration for changes in RHEL9 and report them (#732) - [IPU 8 -> 9]: Check the existence of the custom network-scripts (#729) - [IPU 8 -> 9]: Provide upgrade inhibitor for ipa-server (#765) ## Additional changes interesting for devels - Move target release and flavor specification to a separate lib (#753) - Refactor "transactionworkarounds" actor and fix tests (#759) - Several actors moved to the system_upgrade/common repository (#800, #803, #805, #833) Signed-off-by: Michal Reznik <mreznik@redhat.com>

## Packaging - Requires leapp-framework >= 2.2 - Bump leapp-framework-dependencies to 5 ## Upgrade handling ### Fixes - Fallback to /etc/leapp/repos.d if missing config option instead of using cwd (oamg#849) - Filter out unrelated PES data for the particular IPU path (oamg#789) - Fix bug with existing symlink when migrating YUM configuration files (oamg#811) - Fix creating invalid answerfile in "authselectcheck" actor (oamg#748) - Fix generating of instructions/data for the leapp DNF plugin during the IPU (oamg#754) - Fix generating the target initramfs when additional files and dracut modules are requested to be added (oamg#838) - Fix getting device attribute through udev on Python 3 (oamg#758) - Fix parsing of sysctl output (oamg#793) - Fix processing of merge events from PES data (oamg#768, oamg#825) - Fix random crashes when printing DNF output (oamg#745) - Fix scanning "/etc/default/grub" with empty line (oamg#845) - Fix scanning information about mounted devices (oamg#711) - Fix severities in the "targetuserspacecreator" actor (oamg#751) - Fix the "rerun" command after adding the "--channel" option (oamg#750) - Fix the execution order for the dnf dry run actor (oamg#801) - Skip checking the flavor and target_version upon leapp --resume (oamg#781) - Use more accurate tense in the SELinux messaging (oamg#614) ### Enhancements - Introduce IPU for RHEL 8 to RHEL 9 \o/ - New upgrade paths for RHEL with SAP HANA (oamg#834) - Changed upgrade paths: -- RHEL 7.9 -> [8.4, 8.6] (default: 8.6) -- RHEL 8.6 -> 9.0 -- RHEL with SAP 7.9 -> [8.2, 8.6] (default: 8.2) -- RHEL with SAP 8.6 -> 9.0 - Add 8.6, 9.0 Beta & GA product certificates (oamg#776, oamg#794) - Add detection of enabled YUM & DNF plugins (oamg#703) - Bind the /run/lock dir into the container in the upgrade initramfs env (oamg#831) - Enable RHEL 8 to RHEL 9 upgrades on RHUI for AWS (oamg#828) - Enhance handling selinux related stuff for 8 to 9 upgrade (oamg#749) - Generalize checking of device drivers (oamg#835) - Improve the performance of the leapp execution for "pre first reboot" phases (oamg#741) - Introduce DNFWorkarounds to register scripts to be executed before DNF run (oamg#841) - Introduce DNF modularity support (oamg#672, oamg#799) - Introduce the --report-schema option to control the version of the generated report format (oamg#696) - Introduce the --target option to specify the version of the target system (oamg#780) - Provide the LEAPP_IPU_IN_PROGRESS envar during the IPU (oamg#830) - [IPU 7 -> 8]: Add CUPS actors - cupsscanner, cupscheck, cupsmigrate (oamg#181) - [IPU 7 -> 8]: Convert restrictions with IPv6 mask in "migratentp" actor (oamg#756) - [IPU 7 -> 8]: Handle upgrading Satellite instances (oamg#733) - [IPU 7 -> 8]: Warn about docker deprecation when installed - [IPU 7 -> 8]: Zipl: Inhibit if boot entries share the same kernel image (oamg#816) - [IPU 7 -> 8]: bind configuration check (oamg#521) - [IPU 8 -> 9]: Add actor that ensures ifcfg files work in el9 (oamg#839) - [IPU 8 -> 9]: Add actor that scans for deprecated network settings (oamg#842) - [IPU 8 -> 9]: Add inhibitor FirewalldCheckServiceTftpClient (oamg#792) - [IPU 8 -> 9]: Add inihibtor FirewalldCheckAllowZoneDrifting (oamg#777) - [IPU 8 -> 9]: Add kpatch actor to handle live kernel patching during IPU (oamg#837) - [IPU 8 -> 9]: Add mariadbcheck actor to link upgrade documentation (oamg#836) - [IPU 8 -> 9]: Add postgresqlcheck actor to link upgrade documentation (oamg#802) - [IPU 8 -> 9]: Add scan & checks for VDO devices (oamg#821) - [IPU 8 -> 9]: Apply a new way of disabling SELinux (oamg#769) - [IPU 8 -> 9]: Check SSSD configuration for changes in RHEL9 and report them (oamg#732) - [IPU 8 -> 9]: Check the existence of the custom network-scripts (oamg#729) - [IPU 8 -> 9]: Provide upgrade inhibitor for ipa-server (oamg#765) ## Additional changes interesting for devels - Move target release and flavor specification to a separate lib (oamg#753) - Refactor "transactionworkarounds" actor and fix tests (oamg#759) - Several actors moved to the system_upgrade/common repository (oamg#800, oamg#803, oamg#805, oamg#833) Signed-off-by: Michal Reznik <mreznik@redhat.com>

pirat89 reviewed Nov 30, 2021

View reviewed changes

repos/system_upgrade/el8toel9/actors/checkipaserver/actor.py Outdated Show resolved Hide resolved

pirat89 reviewed Nov 30, 2021

View reviewed changes

repos/system_upgrade/el8toel9/actors/checkipaserver/libraries/checkipaserver.py Outdated Show resolved Hide resolved

pirat89 previously requested changes Nov 30, 2021

View reviewed changes

flo-renaud force-pushed the ipa_inhibitor branch from 93282c8 to 468bcc4 Compare December 6, 2021 14:06

leapp-bot requested a review from a team December 16, 2021 08:04

pirat89 assigned MichalHe Dec 21, 2021

MichalHe reviewed Dec 22, 2021

View reviewed changes

flo-renaud force-pushed the ipa_inhibitor branch from 468bcc4 to eb45b57 Compare December 23, 2021 11:59

flo-renaud force-pushed the ipa_inhibitor branch from eb45b57 to 66c3ea5 Compare January 10, 2022 12:44

fernflower reviewed Jan 11, 2022

View reviewed changes

MichalHe approved these changes Jan 17, 2022

View reviewed changes

MichalHe merged commit de8e6e6 into oamg:master Jan 17, 2022

flo-renaud deleted the ipa_inhibitor branch January 17, 2022 16:33

Rezney mentioned this pull request Mar 12, 2022

Release 0.16.0 #855

Merged

pirat89 added the shortened-urls PR is introducing new shortened red.ht URLs label Aug 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide upgrade inhibitor for ipa-server #765

Provide upgrade inhibitor for ipa-server #765

flo-renaud commented Nov 26, 2021

github-actions bot commented Nov 26, 2021

flo-renaud commented Nov 26, 2021

leapp-bot commented Nov 27, 2021

pirat89 left a comment

flo-renaud commented Dec 6, 2021

flo-renaud commented Dec 13, 2021

leapp-bot commented Dec 16, 2021

MichalHe commented Dec 22, 2021

MichalHe left a comment

MichalHe Dec 22, 2021

flo-renaud Dec 23, 2021

MichalHe Jan 6, 2022 •

edited

Loading

flo-renaud commented Dec 23, 2021

flo-renaud commented Dec 23, 2021

flo-renaud commented Jan 6, 2022

MichalHe commented Jan 6, 2022

Rezney commented Jan 6, 2022

flo-renaud commented Jan 10, 2022

flo-renaud commented Jan 10, 2022

fernflower commented Jan 10, 2022

flo-renaud commented Jan 11, 2022

fernflower commented Jan 11, 2022

fernflower left a comment

flo-renaud commented Jan 17, 2022

MichalHe left a comment

MichalHe commented Jan 17, 2022

flo-renaud commented Jan 17, 2022

	url=MIGRATION_GUIDE, title="Migrating IdM from RHEL 7 to 8",
	url=MIGRATION_GUIDES[get_source_major_version()], title="IdM migration guide",

Provide upgrade inhibitor for ipa-server #765

Provide upgrade inhibitor for ipa-server #765

Conversation

flo-renaud commented Nov 26, 2021

github-actions bot commented Nov 26, 2021

Thank you for contributing to the Leapp project!

flo-renaud commented Nov 26, 2021

leapp-bot commented Nov 27, 2021

pirat89 left a comment

Choose a reason for hiding this comment

flo-renaud commented Dec 6, 2021

flo-renaud commented Dec 13, 2021

leapp-bot commented Dec 16, 2021

MichalHe commented Dec 22, 2021

MichalHe left a comment

Choose a reason for hiding this comment

MichalHe Dec 22, 2021

Choose a reason for hiding this comment

flo-renaud Dec 23, 2021

Choose a reason for hiding this comment

MichalHe Jan 6, 2022 • edited Loading

Choose a reason for hiding this comment

flo-renaud commented Dec 23, 2021

flo-renaud commented Dec 23, 2021

flo-renaud commented Jan 6, 2022

MichalHe commented Jan 6, 2022

Rezney commented Jan 6, 2022

flo-renaud commented Jan 10, 2022

flo-renaud commented Jan 10, 2022

fernflower commented Jan 10, 2022

flo-renaud commented Jan 11, 2022

fernflower commented Jan 11, 2022

fernflower left a comment

Choose a reason for hiding this comment

flo-renaud commented Jan 17, 2022

MichalHe left a comment

Choose a reason for hiding this comment

MichalHe commented Jan 17, 2022

flo-renaud commented Jan 17, 2022

MichalHe Jan 6, 2022 •

edited

Loading