fix UT castDecimalToDecimal and varcharToDecimal

oap-project · Nov 27, 2023 · 052557e · 052557e
1 parent e4f2c01
commit 052557e
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/velox/type/DecimalUtil.h b/velox/type/DecimalUtil.h
@@ -175,7 +175,17 @@ class DecimalUtil {
     }
     // Check overflow.
     if (!valueInPrecisionRange(rescaledValue, toPrecision) || isOverflow) {
-      return std::nullopt;
+      if (throwIfOverflow) {
+        VELOX_USER_FAIL(
+            "Cannot cast DECIMAL '{}' to DECIMAL({}, {})",
+            DecimalUtil::toString(
+                inputValue, DECIMAL(fromPrecision, fromScale)),
+            toPrecision,
+            toScale);
+      } else {
+        isOverflow = true;
+        return std::nullopt;
+      }
     }
     return static_cast<TOutput>(rescaledValue);
   }