[oap ] Fix ORC failed UT

oap-project · Sep 10, 2024 · f770f80 · f770f80
1 parent 61f593e
commit f770f80
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 1 deletion.
diff --git a/velox/dwio/dwrf/reader/SelectiveDecimalColumnReader.h b/velox/dwio/dwrf/reader/SelectiveDecimalColumnReader.h
@@ -41,6 +41,10 @@ class SelectiveDecimalColumnReader : public SelectiveColumnReader {
 
   void getValues(const RowSet& rows, VectorPtr* result) override;
 
+  bool hasBulkPath() const override {
+    return false;
+  }
+
  private:
   template <bool kDense>
   void readHelper(RowSet rows);

diff --git a/velox/dwio/dwrf/reader/SelectiveIntegerDirectColumnReader.h b/velox/dwio/dwrf/reader/SelectiveIntegerDirectColumnReader.h
@@ -64,7 +64,11 @@ class SelectiveIntegerDirectColumnReader
   }
 
   bool hasBulkPath() const override {
-    return true;
+    if (format_ == velox::dwrf::DwrfFormat::kOrc) {
+      return false; // RLEv2 does't support FastPath yet
+    } else {
+      return true;
+    }
   }
 
   void seekToRowGroup(uint32_t index) override {

diff --git a/velox/dwio/dwrf/reader/SelectiveStringDictionaryColumnReader.h b/velox/dwio/dwrf/reader/SelectiveStringDictionaryColumnReader.h
@@ -58,6 +58,14 @@ class SelectiveStringDictionaryColumnReader
       const RowSet& rows,
       const uint64_t* incomingNulls) override;
 
+  bool hasBulkPath() const override {
+    if (version_ == velox::dwrf::RleVersion_1) {
+      return true;
+    } else {
+      return false; // RLEv2 does't support FastPath yet
+    }
+  }
+
   void getValues(const RowSet& rows, VectorPtr* result) override;
 
  private: