[Gluten-1.2] Port #10646 to Branch-1.2 for Put cheap check first in testingTriggerSpill() (#10646) #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiting-chen
changed the title
Summary: testingTriggerSpill() uses 1% cpu in meta internal profiling on release build. This is due to the expensive regex check it does upon entrance of this method. Move pct check up to avoid regex check to reduce the cpu consumption. Pull Request resolved: facebookincubator#10646 Reviewed By: kevinwilfong Differential Revision: D60613614 Pulled By: tanjialiang fbshipit-source-id: 23cbfc89b575343b7e7da1dd7d0eaef63a1ec705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
testingTriggerSpill() uses 1% cpu in meta internal profiling on release build. This is due to the expensive regex check it does upon entrance of this method. Move pct check up to avoid regex check to reduce the cpu consumption.
Pull Request resolved: facebookincubator#10646
Reviewed By: kevinwilfong
Differential Revision: D60613614
Pulled By: tanjialiang
fbshipit-source-id: 23cbfc89b575343b7e7da1dd7d0eaef63a1ec705