Improve MTU Handling #1521
Merged
Improve MTU Handling #1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkrentz
force-pushed
the
mtu-pr
branch
4 times, most recently
from
0814fe0
to
0152bbf
Compare
mrdeep1
reviewed
Sep 17, 2024
by: - Correcting Contiki-NG's value of COAP_DEFAULT_MAX_PDU_RX_SIZE - Denying to create PDUs longer than COAP_DEFAULT_MAX_PDU_RX_SIZE - Using the MTU setter, thereby not overriding stack-specific limits - Using existing constants for L4-specific header sizes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue that this PR solves is that on Contiki-NG one can create PDUs that will not fit in the uIP buffer. The problem is that the value of
COAP_DEFAULT_MAX_PDU_RX_SIZEis incorrect and a check incoap_pdu_initis also flawed. On LWIP, there seems to be an analogous problem.