Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly cargo update in path dependency workspaces. #901

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Explicitly cargo update in path dependency workspaces. #901

merged 2 commits into from
Sep 2, 2024

Commits on Sep 2, 2024

  1. Explicitly cargo update in path dependency workspaces. 

    Resolves a variant of #167 described here:
#167 (comment)

This issue was observed during a CI run of #900, where an older
tokio-stream version was using a brand-new tokio with stronger
guarantees: several types had newly become `UnwindSafe`.

Since the baseline tokio-stream was a registry version, it was using
a fresh lockfile with the latest dependencies. The current arm,
meanwhile, was a path dependency fixed to a specific commit, where
cargo had decided to reuse an older version of tokio without the
`UnwindSafe` trait on those types.

This presented as a (phantom) breaking change: the older tokio-stream's
types were `UnwindSafe` due to auto-trait propagation from a newer tokio
while the newer tokio-stream with an older tokio did not have that trait.

The solution is to explicitly run `cargo update` inside path dependency
workspaces we create. This way, both path dependency and index-based
rustdoc JSON generation happens with the latest versions of the target
library's own dependencies.
    @obi1kenobi
    obi1kenobi committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    9b1139f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into update_path_dependency_lockfile

    @obi1kenobi
    obi1kenobi authored Sep 2, 2024
    Configuration menu
    Copy the full SHA
    01bd39f View commit details
    Browse the repository at this point in the history