Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change primary name for UBERON:2000088 #1461

Open
hdrabkin opened this issue Oct 26, 2018 · 11 comments
Open

change primary name for UBERON:2000088 #1461

hdrabkin opened this issue Oct 26, 2018 · 11 comments
Assignees

Comments

@hdrabkin
Copy link

The primary term name of UBERON:2000088 is YSL with an exact synonym of yolk sac layer. Could we get the primary name and synonym swapped so yolk sac layer is the term name and YSL is the synonym? The primary term name should be spelled out.

Two other term might also need to be changed similarly
E-YSL UBERON_2000309
I-YSL UBERON:2000712

@cmungall
Copy link
Member

@wdahdul are you Ok to make this edit (in the phenoscape-ext module)?

@cmungall
Copy link
Member

Do we get any useful generalization out of the two subclasses in Uberon?

@hdrabkin is this for annotation or ontology axiomatization?

@hdrabkin
Copy link
Author

The latter. If I want to make a logical def for a requested term yolk sac layer development.

@cmungall
Copy link
Member

Thanks for linking the tracker items!

I think we should make the change straight away, and we should also add taxon constraints and make sure the definition is suitably generalized. @sabrinatoro provided some links here:
geneontology/go-ontology#16536 (comment)

Also, e.g: Structure of the Yolk Syncytial Layer in Teleostei and Analogous
Structures in Animals of the Meroblastic Type of Development
https://link.springer.com/article/10.1134%2FS1062359016030055

wdahdul added a commit to obophenotype/uberon-phenoscape-ext that referenced this issue Oct 26, 2018
@wdahdul
Copy link
Member

wdahdul commented Oct 26, 2018

@cmungall Would you add two taxon constraints in this case? e.g., 1) only_in_taxon some 'Vertebrata ' for Teleostei, Myxini, Chondrichthyes, and Lepisosteiformes, and 2) only_in_taxon some Cephalopoda

@hdrabkin
Copy link
Author

But from saying only in taxon 1, could you also then say 'only in taxon 2'? Sounds contradictory.
Also, it's not all vertebrata, right?; only some fish and , not mammal, bird, repitile, etc.?

@cmungall
Copy link
Member

I would treat this as a union.

Seems like an odd union though. Are there meaningful similarities between cephalopod and fish here?

@doughowe
Copy link

doughowe commented Oct 26, 2018

YSL, I-YSL, and E-YSL are terms in ZFA as well. Is it important to have consistency in term naming across these ontologies? Not sure if our anatomy editors would want to make that change. There are other terms handled in a similar way, at least in ZFA, having the abbreviated form as the primary term name when the community uses that format predominantly.

Also, I believe it would be yolk syncytial layer, rather than yolk sac layer? I am assuming those two terms are referring to the same thing...

@cmungall
Copy link
Member

@doughowe - see the linked ticket in ZFA tracker above.

Standard ontology naming conventions are to spell out abbreviations in the primary name. Tools can still choose to use an abbreviation

@doughowe
Copy link

Stellar..looks like you guys are at least a day ahead of me!

@cmungall
Copy link
Member

on second thoughts for TCs I think we should be conservative and only add negative constraints.

Really we should have an ontology class somewhere for "mereoblastic cleavage" and add some TCs there. This could be a subclass of GO:0040016 embryonic cleavage, or of UBERON:0000107 cleavage stage. The uberon YSL would then be an output of this and inherit it's TCs..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants