Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ocamlobjinfo work for Flambda 2 .cmx files #120

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Make ocamlobjinfo work for Flambda 2 .cmx files #120

merged 2 commits into from
Jul 28, 2021

Conversation

mshinwell
Copy link
Collaborator

Straightforward.

@mshinwell mshinwell added the flambda2 Prerequisite for, or part of, flambda2 label Jul 27, 2021
@mshinwell mshinwell requested a review from xclerc July 27, 2021 16:24
xclerc
xclerc approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@xclerc xclerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, for the sake of consistency we might want to
change the format strings to the printf calls
(See suggestions).

tools/objinfo.ml Outdated Show resolved Hide resolved
tools/objinfo.ml Outdated Show resolved Hide resolved
@xclerc
Copy link
Contributor

xclerc commented Jul 28, 2021

(Re-approving after fe5ac06.)

@mshinwell mshinwell merged commit 3578300 into ocaml-flambda:main Jul 28, 2021
mshinwell added a commit to mshinwell/flambda-backend that referenced this pull request Aug 4, 2021
@mshinwell
Make ocamlobjinfo work for Flambda 2 .cmx files (ocaml-flambda#120)
2e251fc
riaqn added a commit to riaqn/flambda-backend that referenced this pull request Feb 23, 2023
@riaqn
Squashed 'ocaml/' changes from a09392d08f..c703f5f777
bcec5fe 
c703f5f777 Incorporate upstream comments into type-variable refactor (ocaml-flambda#121)
362ba2349f Constrain curry modes to increase along applications (ocaml-flambda#108)
b1f0cf9f91 Simplify the extension handling (ocaml-flambda#114)
4fd53a1f6f Remove pat_mode from typedtree (ocaml-flambda#105)
cf6fcbc129 Handle attributes on lambdas with locally abstract types (ocaml-flambda#120)
5fa80fe23f Don't track attributes inside attributes for warning 53 (ocaml-flambda#115)
8a69777a3c Handle unclosed `[: ... :]` patterns (via `Generic_array` machinery) (ocaml-flambda#117)
b0737f46c4 Add promote-one Makefile target (ocaml-flambda#118)
c6ad684608 Refactoring and fixes around module lookup (ocaml-flambda#107)
b0a649516b Add documentation for global constructor arguments (ocaml-flambda#69)
dd79aeca91 Print `nlocal` in the `-d(raw)lambda` output (ocaml-flambda#112)
8035026661 Fix `nlocal` in the generated Lambda for list comprehensions (ocaml-flambda#113)
afbcdf0642 Immutable arrays (ocaml-flambda#47)
bfe1490dfb fix several issues when removing exp_mode (ocaml-flambda#110)
8f46060dc5 Better error message for under-applied functions (ocaml-flambda#74)
27331d848d Consistently use Lmutvar or Lvar in comprehensions (ocaml-flambda#111)
01e965b549 Skip failing test for now
0131357265 Fix test case to use comprehensions_experimental
22a73684b7 Temporarily disable list comprehensions tests due to locals bug
e08377d2d1 Make `comprehensions` into `comprehensions_experimental` for now (ocaml-flambda#109)
947cf892b5 List and array comprehensions (ocaml-flambda#46)
bd9e051900 remove exp_mode from typedtree (ocaml-flambda#100)
a9268d29b4 Fix misplaced attribute warning when using external parser (and some cleanup) (ocaml-flambda#101)
2b33f2465c Refactor toplevel local escape check (ocaml-flambda#104)
ed2aec61c6 Comment functions exported from TyVarEnv.
87838ba0c2 Move new variable creation into TyVarEnv.
a3f60ab586 Encapsulate functions that work with tyvars
43d83a6554 Prevent possibility of forgetting to re-widen
2f3dd34d3d Encapsulate context when narrowing type env't
d78ff6de46 Make immediate64 things mode cross (ocaml-flambda#97)
aa25ab9baf Fix version number (ocaml-flambda#94)
d01ffa06ec Fix .depend file (ocaml-flambda#93)
942f2ab220 Bootstrap (ocaml-flambda#92)
05f7e383d2 Check Menhir version (ocaml-flambda#91)
1569b580b9 Move the CI jobs from 4.12 to 4.14. (ocaml-flambda#90)

git-subtree-dir: ocaml
git-subtree-split: c703f5f7772dd4252405b086be11c15a3c67f2ac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xclerc xclerc xclerc approved these changes

Assignees
No one assigned
Labels
flambda2 Prerequisite for, or part of, flambda2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshinwell @xclerc