Skip DWARF variable info for complicated functions #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshinwell
force-pushed
the
dwarf-function-stack-slot-limit
branch
2 times, most recently
from
c8bba74
to
6df16ef
Compare
mshinwell
force-pushed
the
dwarf-function-stack-slot-limit
branch
from
6df16ef
to
800814c
Compare
xclerc
approved these changes
Aug 10, 2023
tonowak
pushed a commit
to tonowak/flambda-backend
that referenced
this pull request
Aug 11, 2023
Ekdohibs
pushed a commit
to Ekdohibs/flambda-backend
that referenced
this pull request
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a complexity threshold, measured in the number of stack slots used by a function, above which the register availability computations for DWARF variable info will be skipped. The default is 50 stack slots, which seems quite generous. We may in due course be able to remove this, but at present, there are compilation speed problems on particularly large examples. A command-line flag is provided in case an exemption is required.