Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add [@layout_poly] attribute for layout representation polymorphic externals #2229

Merged
merged 31 commits into from
Feb 26, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
764fb9b
wip
alanechang Jan 11, 2024
f3edb0f
remove paren
alanechang Feb 7, 2024
cb556b5
add test when type constructor constrains layout
alanechang Feb 7, 2024
fbfcfff
rename is_lambda_prim to is_builtin_prim
alanechang Feb 8, 2024
d0aa0f5
test&comment about No_native_primitive_with_non_value and Old_style_f…
alanechang Feb 8, 2024
cdd961c
revert indentation change to reduce diff
alanechang Feb 8, 2024
b48299c
make ml/mli def of description_gen consistent
alanechang Feb 8, 2024
bf247f2
fix long lines
alanechang Feb 8, 2024
d202213
comment on make_prim_repr_args
alanechang Feb 8, 2024
daa6253
fix module tests
alanechang Feb 8, 2024
ec2c7f0
rework jkind checks
alanechang Feb 12, 2024
791f820
add comment on extern_repr
alanechang Feb 12, 2024
a1d7455
move make_prim_repr_args comment to mli
alanechang Feb 12, 2024
bdf0cd5
more comments
alanechang Feb 12, 2024
0ba1195
prim_is_layout_representation_polymorphic rename
alanechang Feb 12, 2024
2903843
add test about non-explicitly quantify tvars
alanechang Feb 12, 2024
071ec84
update type_sort_external comment
alanechang Feb 12, 2024
bd6d12f
test update
alanechang Feb 12, 2024
42d67c0
rename to layout_poly and improve error messages
alanechang Feb 12, 2024
e11083c
fix format
alanechang Feb 12, 2024
44dee8f
make the repr checks stronger
alanechang Feb 14, 2024
4efe6e1
rename test files
alanechang Feb 14, 2024
42d8375
register layout_poly in Builtin_attributes
alanechang Feb 21, 2024
2159a82
improve documentation
alanechang Feb 21, 2024
4470b55
code cleanup & rename
alanechang Feb 21, 2024
065db36
more tests for instance_prim
alanechang Feb 21, 2024
7a1c8fc
more documentation and tests around the jkind check
alanechang Feb 21, 2024
da9a0dc
Formatting and minor edits in comments
ccasin Feb 26, 2024
1843228
make unused layout_poly an error
alanechang Feb 26, 2024
b4faa52
update error message
alanechang Feb 26, 2024
2216b47
fix upstream build and bootstrap
alanechang Feb 26, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comment on extern_repr
  • Loading branch information
alanechang committed Feb 21, 2024
commit 791f8203f949d7f97afa9014a977bbf4ae264839
2 changes: 2 additions & 0 deletions ocaml/lambda/lambda.mli
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,8 @@ type primitive =
(* Fetching domain-local state *)
| Pdls_get

(** This is the same as [Primitive.native_repr] but with [Repr_poly]
compiled away. *)
and extern_repr =
alanechang marked this conversation as resolved.
Show resolved Hide resolved
| Same_as_ocaml_repr of Jkind.Sort.const
| Unboxed_float of boxed_float
Expand Down