Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug fixes for middle/backend unboxed array support #2233

Merged
merged 3 commits into from
Jan 18, 2024
Merged

Small bug fixes for middle/backend unboxed array support #2233

merged 3 commits into from
Jan 18, 2024

Conversation

alanechang
Copy link
Contributor

This PR contains fixes for three bugs found when adding frontend support:

  1. array length output needs to be tagged
  2. ref/set operations receive tagged ints as inputs. the process of skipping the custom field needs to be updated
  3. correct symbol names for the custom ops

Each fix is its own commit. Might be easier to review one commit at a time.

mshinwell
mshinwell approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@mshinwell mshinwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were all my bugs, thanks for fixing.

@mshinwell mshinwell merged commit 1ac25f3 into main Jan 18, 2024
16 checks passed
@mshinwell mshinwell deleted the aec/fix-unboxed-arrays branch January 18, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshinwell mshinwell mshinwell approved these changes

Assignees
No one assigned
Labels
unboxed types
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanechang @mshinwell