Compiler flag to disable checkmach #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xclerc
approved these changes
Mar 11, 2024
gretay-js
added a commit
to gretay-js/flambda-backend
that referenced
this pull request
Mar 19, 2024
* Add compiler flag -disable-checkmach * Conservatively assume that all function summaries are Top
Forestryks
pushed a commit
to Forestryks/flambda-backend
that referenced
this pull request
Mar 25, 2024
* Add compiler flag -disable-checkmach * Conservatively assume that all function summaries are Top
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a compiler flag
-disable-checkmachthat disablesthe pass, i.e., both computation of summaries and checking of annotations will be disabledthe computation of summaries, and assumes that all functions may allocate. This is not the same as-zero-alloc-checkcompilation flag that only control the checking and cannot turn off the analsyis and summary computation.The motivation for adding
-disable-checkmachflag is the change in #2290 that may have pathological cases when the analysis is very slow. The flag is intended as a temporary workaround, not a permanent solution for these situations, until the analysis fixpoint computation can be optimized. The downside is that in the meantime uses will fail the check.