Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

float32 otherlib #2492

Merged
merged 180 commits into from
May 9, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
180 commits
Select commit Hold shift + click to select a range
430b6b7
float32 in flambda2
TheNumbat Mar 14, 2024
627203b
fixes
TheNumbat Mar 14, 2024
296e7b8
arm
TheNumbat Mar 14, 2024
a0a2282
more crs
TheNumbat Mar 14, 2024
7458491
primitives
TheNumbat Mar 14, 2024
8644e75
format
TheNumbat Mar 14, 2024
d0342f1
upstream build
TheNumbat Mar 14, 2024
797a7a6
delete array case
TheNumbat Mar 19, 2024
fad1816
casts
TheNumbat Mar 19, 2024
0bd3e82
format
TheNumbat Mar 19, 2024
f195d02
Merge branch 'f32-fl2' into f32-backend
TheNumbat Mar 19, 2024
9c8d442
testsuite cmm parser
TheNumbat Mar 19, 2024
a2af96d
format
TheNumbat Mar 19, 2024
9451a8f
cast fl2
TheNumbat Mar 19, 2024
84e23ff
num conv
TheNumbat Mar 19, 2024
39b36ca
merge
TheNumbat Mar 19, 2024
e42799a
fix name in cfg
TheNumbat Mar 19, 2024
0b86abd
float32 static consts
TheNumbat Mar 19, 2024
2fe6ea4
add test
TheNumbat Mar 19, 2024
7e93f52
fixes
TheNumbat Mar 19, 2024
8d56965
Merge branch 'f32-fl2' into f32-backend
TheNumbat Mar 19, 2024
8ade880
another fix
TheNumbat Mar 19, 2024
7f64da8
Merge branch 'f32-fl2' into f32-backend
TheNumbat Mar 19, 2024
0d24bdd
fix nan test
TheNumbat Mar 19, 2024
0937fc4
actually use cconst_float32
TheNumbat Mar 20, 2024
e7f7b9e
float32 operations
TheNumbat Mar 21, 2024
28c4360
cmm stubs
TheNumbat Mar 21, 2024
ed13892
fix asserts
TheNumbat Mar 21, 2024
2ea3d51
separate storage single and actual float32
TheNumbat Mar 22, 2024
4375a5d
merge
TheNumbat Mar 22, 2024
1da7d02
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Mar 22, 2024
b6662e4
fix cmm test parser again
TheNumbat Mar 22, 2024
3e436c4
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Mar 22, 2024
5b81480
fix operation unboxing
TheNumbat Mar 22, 2024
170a192
oops
TheNumbat Mar 22, 2024
d83be31
comments
TheNumbat Mar 22, 2024
ca93bd7
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Mar 22, 2024
d8663f1
parsecmm again
TheNumbat Mar 22, 2024
e8e169c
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Mar 22, 2024
96403b6
Merge branch 'main' into f32-fl2
TheNumbat Mar 22, 2024
4068688
merge
TheNumbat Mar 22, 2024
15944f5
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Mar 22, 2024
4ff6ad9
fix
TheNumbat Mar 22, 2024
2d2498d
parsecmm again
TheNumbat Mar 22, 2024
52f66d8
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Mar 22, 2024
5ea8e3e
arm
TheNumbat Mar 22, 2024
0ef407b
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Mar 22, 2024
7fbbae6
clean up commit history
TheNumbat Mar 25, 2024
6663075
normalize zero/nan in hash
TheNumbat Mar 26, 2024
3785d6a
Apply suggestions from code review
TheNumbat Mar 26, 2024
62ad563
Update backend/x86_binary_emitter.ml
TheNumbat Apr 1, 2024
3387841
address comments
TheNumbat Apr 2, 2024
134c753
restore copyright headers
TheNumbat Apr 2, 2024
9fa47cd
unify single mem chunks
TheNumbat Apr 2, 2024
d9347fe
fix size_expr f32 const
TheNumbat Apr 2, 2024
a8d5321
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 2, 2024
50aa877
merge
TheNumbat Apr 2, 2024
ccfbe36
merge fix from later pr
TheNumbat Apr 2, 2024
b0d5f27
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 2, 2024
a8f23ed
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 2, 2024
c7437ba
fix comment
TheNumbat Apr 2, 2024
ae04a8e
parsecmm...
TheNumbat Apr 2, 2024
7ea280e
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 2, 2024
d218a6f
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 2, 2024
01c848f
arm build
TheNumbat Apr 2, 2024
ac35a97
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 2, 2024
1f47ecd
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 2, 2024
b13bd15
new machtype component
TheNumbat Apr 2, 2024
300c75a
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 2, 2024
b6f6391
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 2, 2024
062b106
add ext arg test
TheNumbat Apr 2, 2024
1b19d02
fix ext args
TheNumbat Apr 2, 2024
f1daf13
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 2, 2024
bb186b2
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 2, 2024
7eaa6ec
Apply suggestions from code review
TheNumbat Apr 3, 2024
f5766a3
comments
TheNumbat Apr 3, 2024
a42f8f7
use 4b size in selectgen
TheNumbat Apr 3, 2024
380c715
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 3, 2024
9cb2f0f
merge
TheNumbat Apr 3, 2024
e38b256
real f32 ops in f32_by_bit_pattern
TheNumbat Apr 8, 2024
a7b32de
float32 parsing (untested)
TheNumbat Apr 8, 2024
050b46b
install stubs for testsuite
TheNumbat Apr 8, 2024
f899698
merge
TheNumbat Apr 8, 2024
d08462a
merge
TheNumbat Apr 8, 2024
b2ff074
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 8, 2024
5c150cd
merge arm changes
TheNumbat Apr 8, 2024
95bb9b6
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 8, 2024
7d45d1f
Update ocaml/middle_end/flambda/closure_conversion.ml
TheNumbat Apr 9, 2024
64b2663
address comments
TheNumbat Apr 9, 2024
d165586
Merge branch 'f32-fl2' of github.com:ocaml-flambda/flambda-backend in…
TheNumbat Apr 9, 2024
62d2c75
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 9, 2024
9eec365
comment
TheNumbat Apr 9, 2024
0f9dae1
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 9, 2024
bb618c0
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 9, 2024
66187bb
merge
TheNumbat Apr 9, 2024
cbd71a1
simplify locale defs
TheNumbat Apr 9, 2024
fa7870b
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 9, 2024
ebb0d6a
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 9, 2024
5834a7c
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 9, 2024
03ad39a
fix f32 alloc size
TheNumbat Apr 9, 2024
c219e35
fmt
TheNumbat Apr 9, 2024
8e9bdf8
move f32 lib to external
TheNumbat Apr 11, 2024
7f69249
fix build system
TheNumbat Apr 11, 2024
9ac6060
format
TheNumbat Apr 11, 2024
eacd280
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 11, 2024
3b9867a
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 11, 2024
983b270
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 11, 2024
b78a2e4
fix compare
TheNumbat Apr 16, 2024
f551594
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 16, 2024
4daf82d
fix static const
TheNumbat Apr 16, 2024
203d218
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 16, 2024
2925238
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 16, 2024
df8abe2
add neq_float32
TheNumbat Apr 16, 2024
ae3d4a5
preserve width in simplify comparison
TheNumbat Apr 16, 2024
e2bac20
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 16, 2024
04bd989
typo
TheNumbat Apr 16, 2024
77e83d9
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 16, 2024
a12ba29
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 16, 2024
ff8762c
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 16, 2024
2a3a4f2
typo
TheNumbat Apr 16, 2024
fc02a69
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 16, 2024
0cfb535
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 16, 2024
191df17
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 16, 2024
df6688e
another tagging fix
TheNumbat Apr 16, 2024
c50b64f
Merge branch 'f32-fl2' into f32-backend
TheNumbat Apr 16, 2024
555c85b
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 16, 2024
dc60a19
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 16, 2024
8528bab
squash
TheNumbat Apr 16, 2024
612beb2
remove pattern match
TheNumbat Apr 17, 2024
9146703
update test
TheNumbat Apr 17, 2024
4bdc1de
adjustment
TheNumbat Apr 17, 2024
ea62c43
adjustment
TheNumbat Apr 17, 2024
089a0ea
address comment
TheNumbat Apr 19, 2024
cbe341b
whitespace
TheNumbat Apr 19, 2024
d482728
preserve width in negation of other side
TheNumbat Apr 24, 2024
994435e
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 24, 2024
4bbcab3
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat Apr 24, 2024
b0ed404
merge
TheNumbat Apr 26, 2024
3db086b
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 26, 2024
4aaa542
merge
TheNumbat Apr 26, 2024
261bc62
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat Apr 26, 2024
ac288c1
fix arm build
TheNumbat Apr 26, 2024
1792a07
Merge branch 'f32-backend' into f32-fl2-ops
TheNumbat Apr 26, 2024
76ff55f
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 26, 2024
14d6d16
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat Apr 26, 2024
99b0fa8
Merge branch 'main' into f32-fl2-ops
TheNumbat Apr 26, 2024
d1908f5
caml_hash_exn
TheNumbat Apr 26, 2024
096c550
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat Apr 26, 2024
205d415
fix test
TheNumbat Apr 26, 2024
6015401
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat Apr 26, 2024
736b9b4
Refactor otherlibs build (#2477)
TheNumbat Apr 29, 2024
ef742ca
Merge branch 'main' into f32-fl2-ops
TheNumbat Apr 29, 2024
dc44058
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 29, 2024
81ed6dd
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat Apr 29, 2024
28c0b53
Merge branch 'main' into f32-fl2-ops
TheNumbat Apr 30, 2024
e6292a6
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat Apr 30, 2024
9c97040
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat Apr 30, 2024
d36692d
squash
TheNumbat Apr 30, 2024
437e322
add toplevel printing for float32
TheNumbat Apr 30, 2024
5f6c62c
fix deps
TheNumbat Apr 30, 2024
676fe93
delete f32 lit crs
TheNumbat Apr 30, 2024
0767acd
promote tests
TheNumbat Apr 30, 2024
bcab4d2
install floats stubs lib
TheNumbat May 1, 2024
3ce16c1
add s suffix to printer
TheNumbat May 1, 2024
97b165a
test
TheNumbat May 1, 2024
153d894
operator module
TheNumbat May 1, 2024
dff064a
test min_max
TheNumbat May 1, 2024
31be758
fix test
TheNumbat May 1, 2024
ff1dd31
fix float_arith kinds
TheNumbat May 1, 2024
f796c15
Merge branch 'f32-fl2-ops' into f32-backend-ops
TheNumbat May 1, 2024
ecf95a5
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat May 1, 2024
ad615d5
Merge branch 'f32-lit' into f32-lib2
TheNumbat May 1, 2024
3524b17
address comments
TheNumbat May 6, 2024
664faaf
add more string tests
TheNumbat May 7, 2024
58c751d
squash for review
TheNumbat May 7, 2024
0ca2a02
functorize binary_float_comp
TheNumbat May 7, 2024
a0b462d
merge
TheNumbat May 7, 2024
d5a8ce4
Merge branch 'f32-backend-ops' into f32-lit
TheNumbat May 7, 2024
219d2dc
merge
TheNumbat May 7, 2024
7df579a
merge
TheNumbat May 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixes
  • Loading branch information
TheNumbat committed Mar 14, 2024
commit 627203b040a47f8a06eea45e97cf738b6eb19bab
3 changes: 1 addition & 2 deletions middle_end/flambda2/from_lambda/closure_conversion.ml
Original file line number Diff line number Diff line change
Expand Up @@ -512,8 +512,7 @@ let close_c_call acc env ~loc ~let_bound_ids_with_kinds
| _, Same_as_ocaml_repr _ -> None
| _, Unboxed_float Pfloat64 -> Some (P.Box_number (Naked_float, alloc_mode))
| _, Unboxed_float Pfloat32 ->
(* CR mslater: (float32) middle end support *)
assert false
Some (P.Box_number (Naked_float32, alloc_mode))
| _, Unboxed_integer Pnativeint ->
Some (P.Box_number (Naked_nativeint, alloc_mode))
| _, Unboxed_integer Pint32 -> Some (P.Box_number (Naked_int32, alloc_mode))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ let convert_array_kind_for_length kind : P.Array_kind_for_length.t =
| Float_array_opt_dynamic -> Float_array_opt_dynamic

module Array_ref_kind = struct
(* CR mslater: (float32) arrays *)
type t =
| Immediates
| Values
Expand Down
2 changes: 1 addition & 1 deletion middle_end/flambda2/simplify/unboxing/unboxers.ml
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ module Float32 = struct
invalid_const =
Const.naked_float32 Numeric_types.Float32_by_bit_pattern.zero;
unboxing_prim;
prove_simple = T.meet_boxed_float_containing_simple
prove_simple = T.meet_boxed_float32_containing_simple
}
end

Expand Down
3 changes: 3 additions & 0 deletions middle_end/flambda2/types/flambda2_types.mli
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,9 @@ val prove_tagging_of_simple :
val meet_tagging_of_simple :
Typing_env.t -> min_name_mode:Name_mode.t -> t -> Simple.t meet_shortcut

val meet_boxed_float32_containing_simple :
Typing_env.t -> min_name_mode:Name_mode.t -> t -> Simple.t meet_shortcut

val meet_boxed_float_containing_simple :
Typing_env.t -> min_name_mode:Name_mode.t -> t -> Simple.t meet_shortcut

Expand Down
4 changes: 2 additions & 2 deletions middle_end/flambda2/types/grammar/more_type_creators.ml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ let any_tagged_bool = these_tagged_immediates Targetint_31_63.all_bools
let any_naked_bool = TG.these_naked_immediates Targetint_31_63.all_bools

let this_boxed_float32 f alloc_mode =
TG.box_float (TG.this_naked_float32 f) alloc_mode
TG.box_float32 (TG.this_naked_float32 f) alloc_mode

let this_boxed_float f alloc_mode =
TG.box_float (TG.this_naked_float f) alloc_mode
Expand Down Expand Up @@ -117,7 +117,7 @@ let these_boxed_nativeints is alloc_mode =
TG.box_nativeint (these_naked_nativeints is) alloc_mode

let any_boxed_float32 =
TG.box_float TG.any_naked_float32 (Alloc_mode.For_types.unknown ())
TG.box_float32 TG.any_naked_float32 (Alloc_mode.For_types.unknown ())

let any_boxed_float =
TG.box_float TG.any_naked_float (Alloc_mode.For_types.unknown ())
Expand Down
2 changes: 1 addition & 1 deletion middle_end/flambda2/types/grammar/type_grammar.ml
Original file line number Diff line number Diff line change
Expand Up @@ -3066,7 +3066,7 @@ let get_tag_for_block ~block : t =
Naked_immediate (TD.create (Get_tag (alias_type_of K.value block)))

let boxed_float32_alias_to ~naked_float32 =
box_float (Naked_float32 (TD.create_equals (Simple.var naked_float32)))
box_float32 (Naked_float32 (TD.create_equals (Simple.var naked_float32)))

let boxed_float_alias_to ~naked_float =
box_float (Naked_float (TD.create_equals (Simple.var naked_float)))
Expand Down
Loading