-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make local extension point equivalent to local_ expression #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antalsz
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ccasin
added a commit
to ccasin/flambda-backend
that referenced
this pull request
Aug 31, 2022
ccc356dd43 flambda-backend: Prevent dynamic loading of the same .cmxs twice in private mode, etc. (ocaml-flambda#784) 14eb57247e flambda-backend: Make local extension point equivalent to local_ expression (ocaml-flambda#790) 487d11baee flambda-backend: Fix tast_iterator and tast_mapper for include functor. (ocaml-flambda#795) a50a818fa0 flambda-backend: Reduce closure allocation in List (ocaml-flambda#792) 96c9c60d5f flambda-backend: Merge ocaml-jst a775b88500 flambda-backend: Fix ocaml/otherlibs/unix 32-bit build (ocaml-flambda#767) f7c2679d77 flambda-backend: Create object files internally to avoid invoking GAS (ocaml-flambda#757) c7a46bb939 flambda-backend: Bugfix for Cmmgen.expr_size with locals (ocaml-flambda#756) b337cb6015 flambda-backend: Fix build_upstream for PR749 (ocaml-flambda#750) 8e7e81c0ab flambda-backend: Differentiate is_int primitive between generic and variant-only versions (ocaml-flambda#749) git-subtree-dir: ocaml git-subtree-split: ccc356dd437eb505dba5a6efb3c9e460dbe2af6e
mshinwell
added a commit
to mshinwell/flambda-backend
that referenced
this pull request
Oct 24, 2022
25188da695 flambda-backend: Missed comment from PR802 (ocaml-flambda#887) 9469765e42 flambda-backend: Improve the semantics of asynchronous exceptions (new simpler version) (ocaml-flambda#802) d9e4dd0c40 flambda-backend: Fix `make runtest` on NixOS (ocaml-flambda#874) 4bbde7a0f0 flambda-backend: Simpler symbols (ocaml-flambda#753) ef37262ef1 flambda-backend: Add opaqueness to Obj.magic under Flambda 2 (ocaml-flambda#862) a9616e98b1 flambda-backend: Add build system hooks for ocaml-jst (ocaml-flambda#869) 045ef67fdb flambda-backend: Allow the compiler to build with stock Dune (ocaml-flambda#868) 3cac5be480 flambda-backend: Simplify Makefile logic for natdynlinkops (ocaml-flambda#866) c5b12bf362 flambda-backend: Remove unnecessary install lines (ocaml-flambda#860) ff12bbe344 flambda-backend: Fix unused variable warning in st_stubs.c (ocaml-flambda#861) c84976c1a2 flambda-backend: Static check for noalloc: attributes (ocaml-flambda#825) ca56052e19 flambda-backend: Build system refactoring for ocaml-jst (ocaml-flambda#857) 39eb7f9b12 flambda-backend: Remove integer comparison involving nonconstant polymorphic variants (ocaml-flambda#854) c102688f57 flambda-backend: Fix soundness bug by using currying information from typing (ocaml-flambda#850) 6a96b6142d flambda-backend: Add a primitive to enable/disable the tick thread (ocaml-flambda#852) f64370bad9 flambda-backend: Make Obj.dup use a new primitive, %obj_dup (ocaml-flambda#843) 9b78eb2192 flambda-backend: Add test for ocaml-flambda#820 (include functor soundness bug) (ocaml-flambda#841) 8f24346583 flambda-backend: Add `-dtimings-precision` flag (ocaml-flambda#833) 65c2f22d33 flambda-backend: Add test for ocaml-flambda#829 (ocaml-flambda#831) 7b27a49334 flambda-backend: Follow-up PR#829 (comballoc fixes for locals) (ocaml-flambda#830) ad7ec10060 flambda-backend: Use a custom condition variable implementation (ocaml-flambda#787) 3ee650c14d flambda-backend: Fix soundness bug in include functor (ocaml-flambda#820) 2f573789f3 flambda-backend: Static check noalloc (ocaml-flambda#778) aaad625f4d flambda-backend: Emit begin/end region only when stack allocation is enabled (ocaml-flambda#812) 17c7173251 flambda-backend: Fix .cmt for included signatures (ocaml-flambda#803) e11966990e flambda-backend: Increase delays in tests/lib-threads/beat.ml (ocaml-flambda#800) ccc356dd43 flambda-backend: Prevent dynamic loading of the same .cmxs twice in private mode, etc. (ocaml-flambda#784) 14eb57247e flambda-backend: Make local extension point equivalent to local_ expression (ocaml-flambda#790) 487d11baee flambda-backend: Fix tast_iterator and tast_mapper for include functor. (ocaml-flambda#795) a50a818fa0 flambda-backend: Reduce closure allocation in List (ocaml-flambda#792) 96c9c60d5f flambda-backend: Merge ocaml-jst a775b88500 flambda-backend: Fix ocaml/otherlibs/unix 32-bit build (ocaml-flambda#767) f7c2679d77 flambda-backend: Create object files internally to avoid invoking GAS (ocaml-flambda#757) c7a46bb939 flambda-backend: Bugfix for Cmmgen.expr_size with locals (ocaml-flambda#756) b337cb6015 flambda-backend: Fix build_upstream for PR749 (ocaml-flambda#750) 8e7e81c0ab flambda-backend: Differentiate is_int primitive between generic and variant-only versions (ocaml-flambda#749) git-subtree-dir: ocaml git-subtree-split: 25188da6951ae276e561923457fcfeb95b7ef392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cases were handling "extension.local" but not "ocaml.local" or "local"